From: Jerone Young <jyoung5@us.ibm.com>
To: xen-devel <xen-devel@lists.xensource.com>
Cc: Jimi Xenidis <jimix@watson.ibm.com>,
Hollis Blanchard <hollisb@us.ibm.com>
Subject: [PATCH] Remove uses of "packed" attribute from acm.h so PPC Xen will build
Date: Wed, 04 Apr 2007 14:19:20 -0500 [thread overview]
Message-ID: <1175714361.19985.5.camel@laptop> (raw)
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
The use of "packed" attribute is bad for PPC. PPC Xen build checks for
this and will not build if this is in the code.
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
[-- Attachment #2: fix_acm.h --]
[-- Type: text/x-patch, Size: 1965 bytes --]
diff -r a1b17c48fb40 xen/include/public/acm.h
--- a/xen/include/public/acm.h Tue Apr 03 11:44:10 2007 +0100
+++ b/xen/include/public/acm.h Tue Jan 28 15:42:36 2031 -0600
@@ -124,7 +124,7 @@ struct acm_policy_version
{
uint32_t major;
uint32_t minor;
-} __attribute__((packed));
+};
/* each buffer consists of all policy information for
@@ -145,12 +145,12 @@ struct acm_policy_buffer {
uint32_t secondary_policy_code;
uint32_t secondary_buffer_offset;
struct acm_policy_version xml_pol_version; /* add in V3 */
-} __attribute__((packed));
+};
struct acm_policy_reference_buffer {
uint32_t len;
-} __attribute__((packed));
+};
struct acm_chwall_policy_buffer {
uint32_t policy_version; /* ACM_CHWALL_VERSION */
@@ -162,7 +162,7 @@ struct acm_chwall_policy_buffer {
uint32_t chwall_conflict_sets_offset;
uint32_t chwall_running_types_offset;
uint32_t chwall_conflict_aggregate_offset;
-} __attribute__((packed));
+};
struct acm_ste_policy_buffer {
uint32_t policy_version; /* ACM_STE_VERSION */
@@ -170,7 +170,7 @@ struct acm_ste_policy_buffer {
uint32_t ste_max_types;
uint32_t ste_max_ssidrefs;
uint32_t ste_ssid_offset;
-} __attribute__((packed));
+};
struct acm_stats_buffer {
uint32_t magic;
@@ -179,7 +179,7 @@ struct acm_stats_buffer {
uint32_t primary_stats_offset;
uint32_t secondary_policy_code;
uint32_t secondary_stats_offset;
-} __attribute__((packed));
+};
struct acm_ste_stats_buffer {
uint32_t ec_eval_count;
@@ -188,7 +188,7 @@ struct acm_ste_stats_buffer {
uint32_t gt_denied_count;
uint32_t ec_cachehit_count;
uint32_t gt_cachehit_count;
-} __attribute__((packed));
+};
struct acm_ssid_buffer {
uint32_t len;
@@ -200,7 +200,7 @@ struct acm_ssid_buffer {
uint32_t secondary_policy_code;
uint32_t secondary_max_types;
uint32_t secondary_types_offset;
-} __attribute__((packed));
+};
#endif
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
reply other threads:[~2007-04-04 19:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175714361.19985.5.camel@laptop \
--to=jyoung5@us.ibm.com \
--cc=hollisb@us.ibm.com \
--cc=jimix@watson.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.