From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752914AbXDEABn (ORCPT ); Wed, 4 Apr 2007 20:01:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752921AbXDEABn (ORCPT ); Wed, 4 Apr 2007 20:01:43 -0400 Received: from homer.mvista.com ([63.81.120.158]:10836 "EHLO gateway-1237.mvista.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752905AbXDEABm (ORCPT ); Wed, 4 Apr 2007 20:01:42 -0400 Subject: Re: + clocksource-driver-initialize-list-value.patch added to -mm tree From: Daniel Walker To: Jeremy Fitzhardinge Cc: Ingo Molnar , Andrew Morton , tglx@linutronix.de, johnstul@us.ibm.com, LKML , heiko.carstens@de.ibm.com In-Reply-To: <46143941.7050702@goop.org> References: <200704010523.l315NXJP004063@shell0.pdx.osdl.net> <1175417035.28263.42.camel@localhost.localdomain> <1175704712.15973.35.camel@imap.mvista.com> <20070404125853.1cf9b7b7.akpm@linux-foundation.org> <1175717425.15973.61.camel@imap.mvista.com> <20070404203647.GA12563@elte.hu> <1175719489.15973.66.camel@imap.mvista.com> <20070404211514.GA18600@elte.hu> <1175722246.15973.78.camel@imap.mvista.com> <20070404213404.GA21742@elte.hu> <1175723954.15973.96.camel@imap.mvista.com> <46143941.7050702@goop.org> Content-Type: text/plain Date: Wed, 04 Apr 2007 17:00:53 -0700 Message-Id: <1175731253.15973.106.camel@imap.mvista.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2.1 (2.8.2.1-3.fc6) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2007-04-04 at 16:48 -0700, Jeremy Fitzhardinge wrote: > Daniel Walker wrote: > > I vaguely remember, but I don't think this creates a maintenance > > issue .. It's not related to maintenance , it's an issue of creating a > > new clocksource .. My perspective is that it has even less an effect > > than the CLOCK_SOURCE_IS_CONTINUOUS field .. People actually have to > > research that field, but list initialization is fairly clear. > > > > Yes, but its just make-work. It has no bearing on what the clocksource > implementer needs to care about. CLOCK_SOURCE_IS_CONTINUOUS is a > property of the clocksource they're implementing; it matters to them. > But "list"? It's just administration. Setting CLOCK_SOURCE_IS_CONTINUOUS is largely administration , do you know what that flag means? > > The majority method for creating these clocksources is copy&paste, so > > I'm not sure nano argument on this subject particularly relevant .. > > Great, so we end up with some random piece of clocksource internal > implementation detail cut-n-paste replicated all over the kernel. list values and list initialization are hardly internal details , they are commonly used all over the kernel. Daniel