All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	tglx@linutronix.de, johnstul@us.ibm.com,
	LKML <linux-kernel@vger.kernel.org>,
	heiko.carstens@de.ibm.com
Subject: Re: + clocksource-driver-initialize-list-value.patch added to -mm tree
Date: Wed, 04 Apr 2007 17:34:39 -0700	[thread overview]
Message-ID: <1175733279.15973.116.camel@imap.mvista.com> (raw)
In-Reply-To: <461440C9.8040902@goop.org>

On Wed, 2007-04-04 at 17:20 -0700, Jeremy Fitzhardinge wrote:
> Daniel Walker wrote:
> > Setting CLOCK_SOURCE_IS_CONTINUOUS is largely administration , do you
> > know what that flag means?
> >   
> 
> Sure, but at least it has something to do with clocks and time.
> 
> > list values and list initialization are hardly internal details , they
> > are commonly used all over the kernel.
> >   
> 
> The fact that a list is used to string together clocksource structures
> is an internal detail of the clock subsystem.  It's annoying that there
> has to be a list head in the clocksource structure, but at least as a
> clocksource implementer I can ignore it, and if it ever gets changed to
> something else I can keep ignoring it.  Your change makes it something
> that gets pointlessly replicated all over the kernel.

It's already been discussed in the past, but the clocksource structure
is already very simple.. Adding a list initializer doesn't change
anything..

Daniel


  reply	other threads:[~2007-04-05  0:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200704010523.l315NXJP004063@shell0.pdx.osdl.net>
2007-04-01  8:43 ` + clocksource-driver-initialize-list-value.patch added to -mm tree Thomas Gleixner
2007-04-04 16:38   ` Daniel Walker
2007-04-04 19:58     ` Andrew Morton
2007-04-04 20:10       ` Daniel Walker
2007-04-04 20:36         ` Ingo Molnar
2007-04-04 20:44           ` Daniel Walker
2007-04-04 21:15             ` Ingo Molnar
2007-04-04 21:30               ` Daniel Walker
2007-04-04 21:34                 ` Ingo Molnar
2007-04-04 21:59                   ` Daniel Walker
2007-04-04 23:48                     ` Jeremy Fitzhardinge
2007-04-05  0:00                       ` Daniel Walker
2007-04-05  0:20                         ` Jeremy Fitzhardinge
2007-04-05  0:34                           ` Daniel Walker [this message]
2007-04-05  6:02                             ` Thomas Gleixner
2007-04-05  7:51                             ` Ingo Molnar
2007-04-05 11:35                               ` Daniel Walker
2007-04-04 20:48           ` Andrew Morton
2007-04-04 21:47             ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175733279.15973.116.camel@imap.mvista.com \
    --to=dwalker@mvista.com \
    --cc=akpm@linux-foundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jeremy@goop.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.