From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: Re: [Xen-changelog] [xen-unstable] xen: Split
	domain_flags into discrete first-class fields in the
Date: Thu, 05 Apr 2007 12:08:18 -0500
Message-ID: <1175792898.20895.26.camel@basalt>
References: <C23ADAC6.CDFE%keir@xensource.com>
Reply-To: Hollis Blanchard <hollisb@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C23ADAC6.CDFE%keir@xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir@xensource.com>
Cc: xen-devel <xen-devel@lists.xensource.com>, xen-ppc-devel <xen-ppc-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2007-04-05 at 16:56 +0100, Keir Fraser wrote:
> On 5/4/07 16:44, "Hollis Blanchard" <hollisb@us.ibm.com> wrote:
> 
> > This is an interface problem: using the interface in a way that works on
> > x86 fails on other architectures. PLEASE let's redefine the interface to
> > prevent this from happening. In this case, that means replacing the
> > xchg() macro with
> >         static inline xchg(atomic_t *ptr, atomic_t val)
> > and changing the type of 'is_dying'.
> 
> Just need to define bool_t appropriately. What do you need: a long?

An int would be fine, and that would solve today's problem.

How will that prevent the same problem from recurring in the future?

-- 
Hollis Blanchard
IBM Linux Technology Center