From: Jeremy Jackson <jerj@coplanar.net>
To: bridge@osdl.org
Subject: [Bridge] two fields are missing in brctl output when using /sys
Date: Thu, 05 Apr 2007 16:10:59 -0400 [thread overview]
Message-ID: <1175803859.24828.3.camel@ragnarok> (raw)
I've noticed for a while that
# brctl showstp
output is showing 0 for port_no and port_id
It seems that somewhere in 2.6 sysfs land the following items got
printed in hexadecimal, and brctl code was parsing for decimal only
doug:/sys/class/net/eth0/brport# cat port_id
0x8001
doug:/sys/class/net/eth0/brport# cat port_no
0x1
The following patch to bridge-utils (git and 1.2 release) lets it do the
right thing:
diff -ur bridge-utils-1.2/libbridge/libbridge_devif.c
bridge-utils/libbridge/lib
bridge_devif.c
--- bridge-utils-1.2/libbridge/libbridge_devif.c 2007-04-05
16:02:58.2870
22220 -0400
+++ bridge-utils/libbridge/libbridge_devif.c 2007-04-05
14:51:19.362040447 -0
400
@@ -56,7 +56,7 @@
if (!f)
fprintf(stderr, "%s: %s\n", dev, strerror(errno));
else {
- fscanf(f, "%i", &value);
+ fscanf(f, "%d", &value);
fclose(f);
}
return value;
Please CC replies as I'm not subscribed.
--
Jeremy Jackson
jerj@coplanar.net Email/Jabber/Google Talk/MSN
(519)489-4903
Coplanar Networks
http://www.coplanar.net
next reply other threads:[~2007-04-05 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 20:10 Jeremy Jackson [this message]
2007-05-08 18:11 ` [Bridge] two fields are missing in brctl output when using /sys Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175803859.24828.3.camel@ragnarok \
--to=jerj@coplanar.net \
--cc=bridge@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.