From: Thomas Gleixner <tglx@linutronix.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] the scheduled -EINVAL for invalid timevals in setitimer
Date: Fri, 06 Apr 2007 12:29:19 +0200 [thread overview]
Message-ID: <1175855360.28263.439.camel@localhost.localdomain> (raw)
In-Reply-To: <20070406102036.GF29169@stusta.de>
On Fri, 2007-04-06 at 12:20 +0200, Adrian Bunk wrote:
> As scheduled, do_setitimer() now returns -EINVAL for invalid timeval.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Ha, you beat me by a minute :)
> - check_itimerval(value);
> + if (unlikely(!timeval_valid(&value->it_value) || !timeval_valid(&value->it_interval)))
> + return -EINVAL;
>
Please make this:
+ if (!timeval_valid(&value->it_value) ||
+ !timeval_valid(&value->it_interval))
+ return -EINVAL;
tglx
next prev parent reply other threads:[~2007-04-06 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 10:20 [2.6 patch] the scheduled -EINVAL for invalid timevals in setitimer Adrian Bunk
2007-04-06 10:29 ` Thomas Gleixner [this message]
2007-04-14 15:03 ` Adrian Bunk
2007-04-15 3:29 ` Thomas Gleixner
2007-04-21 0:09 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175855360.28263.439.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.