From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 23 Oct 2001 08:04:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 23 Oct 2001 08:04:16 -0400 Received: from t2.redhat.com ([199.183.24.243]:38638 "HELO executor.cambridge.redhat.com") by vger.kernel.org with SMTP id ; Tue, 23 Oct 2001 08:04:03 -0400 To: "David S. Miller" Cc: bcrl@redhat.com, alan@lxorguk.ukuu.org.uk, hawkes@oss.sgi.com, linux-kernel@vger.kernel.org, torvalds@transmeta.com Subject: Re: [PATCH] gcc 3.0.1 warnings about multi-line literals In-Reply-To: Message from "David S. Miller" of "Mon, 22 Oct 2001 14:39:58 PDT." <20011022.143958.78707983.davem@redhat.com> User-Agent: EMH/1.14.1 SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/20.7 (i386-redhat-linux-gnu) MULE/4.0 (HANANOEN) MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Date: Tue, 23 Oct 2001 13:04:27 +0100 Message-ID: <11760.1003838667@warthog.cambridge.redhat.com> From: David Howells Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org "David S. Miller" wrote: > /* try atomic lock inline, if that fails, spin out of line */ > "\tbtsl $1,%0\n" > > It's only gross because you decided to make it so, try: > > "btsl $1,%0\n\t" You can also do things like: " btsl $1,%0 \n" " bne 2f \n" "1: \n" " .section .text.lock \n" " \n" "2: cmpl $0,%0 \n" " bne 2b \n" " rep ; nop \n" " jmpl 1b \n" " \n" " .section .previous \n" using tabs or spaces to pad out the assembly. David