Re: [BTT PATCH] Add back in combined seek output file

[Ming Zhang <blackmagic02881@gmail.com>]

On Tue, 2007-04-10 at 13:18 -0400, Alan D. Brunelle wrote:
> Ming Zhang wrote:
> > On Tue, 2007-04-10 at 13:04 -0400, Alan D. Brunelle wrote:
> >   
> >> @@ -149,9 +150,12 @@ void seeki_add(void *handle, struct io *iop)
> >>         struct seeki *sip = handle;
> >>         long long dist = seek_dist(sip, iop);
> >>         FILE *fp = IOP_READ(iop) ? sip->rfp : sip->wfp;
> >> +       double tstamp = BIT_TIME(iop->t.time);
> >>  
> >>         if (fp)
> >> -               fprintf(fp, "%15.9lf %13lld\n", BIT_TIME(iop->t.time),
> >> dist);
> >> +               fprintf(fp, "%15.9lf %13lld\n", tstamp, dist);
> >> +       if (sip->cfp)
> >> +               fprintf(sip->cfp, "%15.9lf %13lld\n", tstamp, dist);
> >>   
> >>     
> >
> > thx for adding this. it might be better if in combined file, print out
> > current io is read or write. 
> >
> > Ming
> >
> >   
> I could do this - very easily - but then the question is the format:
> 
> - ASCII ("read" "write")
> - Binary (0 = write, 1 = read (or vice versa))
> 
> It doesn't matter much to me...

r/w. easier for grep.

> 
> Alan
> -
> To unsubscribe from this list: send the line "unsubscribe linux-btrace" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html