From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sebastian Siewior <bigeasy@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC 1/3] cryptoapi: AES with AltiVec support
Date: Thu, 12 Apr 2007 08:22:06 +1000 [thread overview]
Message-ID: <1176330126.8061.110.camel@localhost.localdomain> (raw)
In-Reply-To: <20070411165702.256910000@linux.vnet.ibm.com>>
> ==================================================================
> --- ps3-linux.orig/crypto/Makefile
> +++ ps3-linux/crypto/Makefile
> @@ -48,3 +48,7 @@ obj-$(CONFIG_CRYPTO_MICHAEL_MIC) += mich
> obj-$(CONFIG_CRYPTO_CRC32C) += crc32c.o
>
> obj-$(CONFIG_CRYPTO_TEST) += tcrypt.o
> +
> +CFLAGS_aes-altivec.o += -O3 -maltivec -mcpu=cell
> +aes_altivec-objs := aes-alti.o aes-altivec.o
> +obj-$(CONFIG_CRYPTO_AES_ALTIVEC) += aes_altivec.o
Ideally (and I know the RAID6 code isnt doing it), the
code that contains enable_kernel_altivec/disable_kernel_altivec should
-not- itself be compiled with -malitvec. You don't want the compiler to
"inadvertently" generate altivec instructions outside of those calls (in
the function prolog for example).
I noticed quite a bit of memcpy's around too... see if you can limit
usage of these.
Ben.
next prev parent reply other threads:[~2007-04-11 22:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-11 16:49 [RFC 0/3] Experiments with AES-AltiVec Sebastian Siewior
2007-04-11 16:49 ` [RFC 1/3] cryptoapi: AES with AltiVec support Sebastian Siewior
2007-04-11 18:24 ` Arnd Bergmann
2007-04-12 13:40 ` Sebastian Siewior
2007-04-11 22:22 ` Benjamin Herrenschmidt [this message]
2007-04-12 7:45 ` Sebastian Siewior
2007-04-12 8:39 ` Benjamin Herrenschmidt
2007-04-11 16:49 ` [RFC 2/3] PowerPC: lazy altivec enabling in kernel Sebastian Siewior
2007-04-11 16:49 ` [RFC 3/3] cryptoapi: speed test Sebastian Siewior
-- strict thread matches above, loose matches on Subject: below --
2007-04-17 11:52 [RFC 0/3] Experiments with AES-AltiVec, part 2 Sebastian Siewior
2007-04-17 11:52 ` [RFC 1/3] cryptoapi: AES with AltiVec support Sebastian Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176330126.8061.110.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=bigeasy@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.