From: "J. Mayer" <l_indien@magic.fr>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] PPC termios structure ordering
Date: Wed, 18 Apr 2007 20:34:35 +0200 [thread overview]
Message-ID: <1176921275.6333.72.camel@rapid> (raw)
In-Reply-To: <Pine.LNX.4.64.0704171617360.22280@trantor.stuart.netsweng.com>
On Tue, 2007-04-17 at 16:20 -0400, Stuart Anderson wrote:
> Just found a small problem w/ the termios structure as defined for PPC
> linux user. It doesn't match the one in include/asm-powerpc/termbits.h.
>
> Index: linux-user/ppc/termbits.h
> ===================================================================
> --- linux-user/ppc/termbits.h (revision 44)
> +++ linux-user/ppc/termbits.h (working copy)
> @@ -7,8 +7,8 @@
> unsigned int c_oflag; /* output mode flags */
> unsigned int c_cflag; /* control mode flags */
> unsigned int c_lflag; /* local mode flags */
> + unsigned char c_cc[TARGET_NCCS]; /* control
> characters */
> unsigned char c_line; /* line discipline */
> - unsigned char c_cc[TARGET_NCCS]; /* control
> characters */
> unsigned int c_ispeed; /* input speed */
> unsigned int c_ospeed; /* output speed */
> };
>
>
> With this change, both host and target 'stty -a' give the same output.
Thanks. I'll take a better look to this patch then apply. There maybe
the same issue in the ppc64 strucutre ?
--
J. Mayer <l_indien@magic.fr>
Never organized
next prev parent reply other threads:[~2007-04-18 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 20:20 [Qemu-devel] [PATCH] PPC termios structure ordering Stuart Anderson
2007-04-18 18:34 ` J. Mayer [this message]
2007-04-18 18:47 ` Stuart Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176921275.6333.72.camel@rapid \
--to=l_indien@magic.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.