From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993167AbXDSITb (ORCPT ); Thu, 19 Apr 2007 04:19:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S2993185AbXDSIEP (ORCPT ); Thu, 19 Apr 2007 04:04:15 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:45797 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993181AbXDSIEE (ORCPT ); Thu, 19 Apr 2007 04:04:04 -0400 From: "Eric W. Biederman" To: " Cc: , Oleg Nesterov , Christoph Hellwig , , "Eric W. Biederman" , Neil Brown Subject: [PATCH] md: Remove broken SIGKILL support Date: Thu, 19 Apr 2007 01:59:05 -0600 Message-Id: <1176969641308-git-send-email-ebiederm@xmission.com> X-Mailer: git-send-email 1.5.1.1.g2de0 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org From: Eric W. Biederman Currently md_thread calls allow_signal so it can receive a SIGKILL but then does nothing with it except flush the sigkill so that it not can use an interruptible sleep. This whole dance is silly so remove the unnecessary and broken signal handling logic. Cc: Neil Brown Signed-off-by: Eric W. Biederman --- drivers/md/md.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 1299c23..dfd0cb9 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -4542,17 +4542,11 @@ static int md_thread(void * arg) */ current->flags |= PF_NOFREEZE; - allow_signal(SIGKILL); while (!kthread_should_stop()) { /* We need to wait INTERRUPTIBLE so that * we don't add to the load-average. - * That means we need to be sure no signals are - * pending */ - if (signal_pending(current)) - flush_signals(current); - wait_event_interruptible_timeout (thread->wqueue, test_bit(THREAD_WAKEUP, &thread->flags) -- 1.5.0.g53756