From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Luke Browning <lukebr@linux.vnet.ibm.com>
Cc: Olof Johansson <olof@lixom.net>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
cbe-oss-dev@ozlabs.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] powerpc: 64K page support for kexec
Date: Thu, 26 Apr 2007 08:19:45 +1000 [thread overview]
Message-ID: <1177539585.14873.202.camel@localhost.localdomain> (raw)
In-Reply-To: <1177529739.24866.34.camel@luke-laptop>
On Wed, 2007-04-25 at 16:35 -0300, Luke Browning wrote:
> This patch fixes a couple of kexec problems related to 64K page
> support in the kernel. kexec issues a tlbie for each pte. The
> parameters for the tlbie are the page size and the virtual address.
> Support was missing for the computation of these two parameters
> for 64K pages. This patch adds that support.
>
> Signed-off-by: Luke Browning <lukebrowning@us.ibm.com>
Quick look: looks good to me. I suppose you verified it works well
too :-)
(Have you added some debug to check we get the 16M case right ?)
Note that Milton is against using BUG_ON's in here since that code is
used for crash dumps.
Appart from that,
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cheers,
Ben.
next prev parent reply other threads:[~2007-04-25 22:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 18:31 [PATCH] 64K page support for kexec Luke Browning
2007-04-24 19:43 ` Olof Johansson
2007-04-24 22:50 ` Benjamin Herrenschmidt
2007-04-24 23:07 ` Olof Johansson
2007-04-25 5:48 ` Milton Miller
2007-04-25 19:35 ` [PATCH v2] powerpc: " Luke Browning
2007-04-25 22:19 ` Benjamin Herrenschmidt [this message]
2007-04-26 15:28 ` Luke Browning
2007-04-27 4:36 ` [PATCH v3] " Milton Miller
2007-04-27 14:42 ` Luke Browning
2007-04-27 16:51 ` Milton Miller
2007-04-27 16:22 ` [PATCH v4] " Luke Browning
2007-04-27 16:59 ` Milton Miller
2007-04-27 17:30 ` Luke Browning
2007-04-27 18:23 ` Haren Myneni
2007-04-29 5:35 ` Milton Miller
2007-04-29 8:30 ` Paul Mackerras
2007-04-29 9:31 ` Benjamin Herrenschmidt
2007-04-29 13:27 ` Segher Boessenkool
2007-04-29 22:49 ` Benjamin Herrenschmidt
2007-04-26 7:15 ` [PATCH v2] " Olof Johansson
2007-04-24 22:48 ` [PATCH] " Benjamin Herrenschmidt
2007-04-25 13:06 ` Luke Browning
2007-04-25 22:11 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2007-04-26 22:23 [PATCH v3] powerpc: " Luke Browning
2007-04-26 22:32 ` Olof Johansson
2007-05-02 14:19 ` [PATCH v4] " Luke Browning
2007-05-03 13:45 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1177539585.14873.202.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=lukebr@linux.vnet.ibm.com \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.