From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] pygrub: look harder for elilo.conf Date: Wed, 02 May 2007 21:53:20 -0600 Message-ID: <1178164400.28577.67.camel@bling> References: <20070503024240.GA8126@fc.hp.com> <20070503034814.GA23181@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070503034814.GA23181@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Daniel P. Berrange" Cc: xen-devel@lists.xensource.com, keir@xensource.com, xen-ia64-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, 2007-05-03 at 04:48 +0100, Daniel P. Berrange wrote: > On Wed, May 02, 2007 at 10:42:44PM -0400, Aron Griffis wrote: > > > > if platform.machine() == 'ia64': > > self.cf = grub.LiloConf.LiloConfigFile() > > - file_list = ("/efi/redhat/elilo.conf",) > > + # common distributions > > + file_list = ("/efi/debian/elilo.conf", "/efi/gentoo/elilo.conf", > > + "/efi/redflag/elilo.conf", "/efi/redhat/elilo.conf", > > + "/efi/SuSE/elilo.conf",) > > How about simply having it iterate over every first level subdirectory of /efi, > ie basically looking for /efi/*/elilo.conf rather than hardcoding a small > list of distros ? I think Aron looked into it briefly, but it wasn't clear how to do that in libfsimage. If it can be done, that certainly sounds like less maintenance. Thanks, Alex -- Alex Williamson HP Open Source & Linux Org.