Re: [PATCH] packed pixel image blit optimizations.

["Antonino A. Daplas" <adaplas@gmail.com>]

On Thu, 2007-05-03 at 20:34 +0100, James Simmons wrote:
> > > > > This patch is the start of my original work. The goal was:
> > > > > 
> > > > > 1) One function for to draw at any color depth.
> > > > > 
> > > > > 2) 16 color image data does need special padding.
> > > > > 
> > > > > 3) Use fb_pixmap to control drawing to the hardware.
> > > > 
> > > > I'm getting rejects with this patch.  Did you benchmark this and
> > > > compared the performance with the old one?
> > > 
> > > Need to update patch to newest kernel. Not yet, there are still bugs to 
> > > hammer away on.
> > 
> > I don't have to test the patch to see that it is not endian-correct and
> > that it will be many times slower than the old code.
> 
> I have tested on big endian framebuffers and it does work.

How about little-endian?

>  I was attempting
> to shrink the code for embedded devices. We can have the fastest code possible
> but its no good if a cell phone can't run it :-(

Nonsense, the difference is a few kb at most. And I'm not talking about
a few percent speed difference, I'm talking 2, 3 maybe 5x slower.

Please do basic tests first.

Tony


> 


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/