From: Alex Williamson <alex.williamson@hp.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: Is patches/linux-2.6.18/xen-hotplug.patch still necessary?
Date: Wed, 09 May 2007 09:07:20 -0600 [thread overview]
Message-ID: <1178723240.6512.2.camel@lappy> (raw)
In-Reply-To: <C2673151.703F%Keir.Fraser@cl.cam.ac.uk>
On Wed, 2007-05-09 at 08:05 +0100, Keir Fraser wrote:
> On 8/5/07 23:26, "Alex Williamson" <alex.williamson@hp.com> wrote:
>
> > Is the patch below, that's currently in the Xen tree, still
> > necessary? The original commit comment indicates this is so things like
> > 'top' don't get upset during CPU hotplugs. But should that be handled
> > by the hotplug infrastructure in the kernel (or top itself)?
>
> It has to be handled in top itself. With some versions at least it was the
> case that top would crash when CPUs where hot-unplugged. If you revert that
> patch, does your version of top work okay in the hot-unplug case (you have
> to run top across the unplug operation to see if it will crash or not)?
Top still crashes without that patch, but the patch just hides the
problem. Top also crashes during a CPU hotplug operation on bare metal.
I think this patch causes more problems than if fixes. Thanks,
Alex
--
Alex Williamson HP Open Source & Linux Org.
next prev parent reply other threads:[~2007-05-09 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 22:26 Is patches/linux-2.6.18/xen-hotplug.patch still necessary? Alex Williamson
2007-05-09 7:05 ` Keir Fraser
2007-05-09 13:52 ` Dave Lively
2007-05-09 15:07 ` Alex Williamson [this message]
2007-05-09 15:32 ` Keir Fraser
2007-05-09 15:38 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178723240.6512.2.camel@lappy \
--to=alex.williamson@hp.com \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.