All of lore.kernel.org
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Florian Fainelli <florian.fainelli@telecomint.eu>
Cc: Mark Brown <broonie@sirena.org.uk>,
	netdev@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: Network activity LED trigger
Date: Thu, 10 May 2007 16:27:28 -0400	[thread overview]
Message-ID: <1178828848.4062.104.camel@localhost> (raw)
In-Reply-To: <200705102121.07962.florian.fainelli@telecomint.eu>


On Thu, 2007-10-05 at 21:21 +0200, Florian Fainelli wrote:

> Netdev people can probably comment on the place of ledtrig_network_activity(), 
> which is probably not adequate. Also the ledtrig_network_activity can be 
> network device specific for instance.

Thanks for CCing me Florian.
Yes, ledtrig_network_activity() should be device specific - given the
spot you have it at. Just pass dev->name for example and filter on
whether the user wanted that specific device.

Additionaly is there a way to sort of light different colors depending
whether it is an incoming packet or outgoing?
Then you can pass a hook number OUT in the case where you have
ledtrig_network_activity() at the moment. This way we can add
multiple hooks within the network stack.
I dont remember the original patches you posted, but could you have 
multiple LEDs as well?

cheers,
jamal




  reply	other threads:[~2007-05-10 20:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-01 21:41 Network activity LED trigger Florian Fainelli
2007-03-02 12:58 ` Florian Fainelli
2007-03-02 14:11   ` jamal
2007-03-02 14:16     ` Florian Fainelli
2007-03-02 15:16       ` jamal
2007-03-02 16:03         ` Richard Purdie
2007-03-02 16:19           ` jamal
2007-05-10 19:21       ` Florian Fainelli
2007-05-10 20:27         ` jamal [this message]
2007-03-03  2:20 ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2007-05-23 21:02 Florian Fainelli
2007-05-23 22:12 ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1178828848.4062.104.camel@localhost \
    --to=hadi@cyberus.ca \
    --cc=broonie@sirena.org.uk \
    --cc=florian.fainelli@telecomint.eu \
    --cc=netdev@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.