From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: RE: [PATCH] Re: [Xen-staging] [xen-unstable] [qemu] Removeatomic_set_bit, atomic_clear_bit and ia64_intrinsic.h and its Date: Thu, 10 May 2007 15:09:47 -0600 Message-ID: <1178831387.27751.31.camel@bling> References: <200705101500.l4AF0N4b027027@latara.uk.xensource.com> <1178814917.27751.8.camel@bling> <0326530267625D42A4E36594FDD0D1437576D2@exchpamain.ad.xensource.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <0326530267625D42A4E36594FDD0D1437576D2@exchpamain.ad.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christian Limpach Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, 2007-05-10 at 13:01 -0700, Christian Limpach wrote: > > ia64intrin.h is all but empty in gcc 4.1.2, so there's no point in > > including it. dm-exec is still making use of a few of these > > too, but I > > guess it's easy enough to inline them there. Patch below. Thanks, > > Would it also work to just leave the include in exec-all.h? I was > confused and thought that it was a local include which is why I put > #ifndef CONFIG_DM around all the testandset definitions. > > So, if I remove the #ifndef CONFIG_DM, anything including exec-all.h > should still compile, right? Do I still need the extra #define's in > that case? ia64intrin.h is basically empty, so making it included for the dm-exec build doesn't really help. The defines still need to come from somewhere. We could replace with , but for this trivial case, I'd rather not get tied up including kernel headers in userspace tools. Thanks, Alex -- Alex Williamson HP Open Source & Linux Org.