From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] pasemi: electra IDE/pata_platform glue Date: Sun, 13 May 2007 18:01:50 +1000 Message-ID: <1179043310.32247.58.camel@localhost.localdomain> References: <20070512145041.GA13025@lixom.net> <200705130111.03153.arnd@arndb.de> <20070513005830.38ba8e3b@the-village.bc.nu> <200705130248.22844.arnd@arndb.de> <1179022810.32247.54.camel@localhost.localdomain> <20070513061954.GA16623@lixom.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from gate.crashing.org ([63.228.1.57]:40484 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755198AbXEMICJ (ORCPT ); Sun, 13 May 2007 04:02:09 -0400 In-Reply-To: <20070513061954.GA16623@lixom.net> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Olof Johansson Cc: Arnd Bergmann , linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org, paulus@samba.org, Alan Cox > Great. That should fit perfectly with the glue I have now, it'll turn > into the constructor instead. > > I honestly don't see what the benefit is of this recent obsession > with creating of_platform devices for every new device that's not > PCI, especially when there's an already well-fitting driver in the > traditional platform model. It's not like the code to link the two is > large and complex. I agree. > Also, in this particular case, the bindings are not standardized, and > there's a good chance that whatever new platform uses a similar device > will need to do something slightly different. Yup. Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 95A5DDDEB8 for ; Sun, 13 May 2007 18:02:06 +1000 (EST) Subject: Re: [PATCH] pasemi: electra IDE/pata_platform glue From: Benjamin Herrenschmidt To: Olof Johansson In-Reply-To: <20070513061954.GA16623@lixom.net> References: <20070512145041.GA13025@lixom.net> <200705130111.03153.arnd@arndb.de> <20070513005830.38ba8e3b@the-village.bc.nu> <200705130248.22844.arnd@arndb.de> <1179022810.32247.54.camel@localhost.localdomain> <20070513061954.GA16623@lixom.net> Content-Type: text/plain Date: Sun, 13 May 2007 18:01:50 +1000 Message-Id: <1179043310.32247.58.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, Alan Cox , Arnd Bergmann , linux-ide@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > Great. That should fit perfectly with the glue I have now, it'll turn > into the constructor instead. > > I honestly don't see what the benefit is of this recent obsession > with creating of_platform devices for every new device that's not > PCI, especially when there's an already well-fitting driver in the > traditional platform model. It's not like the code to link the two is > large and complex. I agree. > Also, in this particular case, the bindings are not standardized, and > there's a good chance that whatever new platform uses a similar device > will need to do something slightly different. Yup. Ben.