From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] PV driver compatibility patch Date: Tue, 15 May 2007 18:11:56 +0100 Message-ID: <1179249116.26437.39.camel@localhost.localdomain> References: <46499FCB.E57C.0030.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <46499FCB.E57C.0030.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ky Srinivasan Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Isn't there already enough compat shim in unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h for this stuff? xenbus_probe.c already has the required #include, what is the error you saw? Ian. On Tue, 2007-05-15 at 11:05 -0600, Ky Srinivasan wrote: > This patch fixes compilation issues on 2.6.16 kernels. > > Signed-off-by: K. Y. Srinivasan > > --- > linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_probe.c 2007-05-14 > 13:45:04.000000000 -0400 > +++ > linux-2.6-xen-sparse-new/drivers/xen/xenbus/xenbus_probe.c 2007-05-15 > 10:55:31.000000000 -0400 > @@ -67,8 +67,11 @@ > static unsigned long xen_store_mfn; > > extern struct mutex xenwatch_mutex; > - > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,17) > +static struct notifier_block *xenstore_chain; > +#else > static ATOMIC_NOTIFIER_HEAD(xenstore_chain); > +#endif