From: jamal <hadi@cyberus.ca>
To: Sridhar Samudrala <sri@us.ibm.com>
Cc: David Miller <davem@davemloft.net>,
xma@us.ibm.com, rdreier@cisco.com, ak@suse.de,
krkumar2@in.ibm.com, netdev@vger.kernel.org,
netdev-owner@vger.kernel.org, ashwin.chaugule@celunite.com,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
Gagan Arneja <gagan@vmware.com>
Subject: Re: [WIP] [PATCH] WAS Re: [RFC] New driver API to speed up small packets xmits
Date: Wed, 16 May 2007 18:52:12 -0400 [thread overview]
Message-ID: <1179355932.4084.19.camel@localhost> (raw)
In-Reply-To: <1179353523.10414.12.camel@w-sridhar2.beaverton.ibm.com>
On Wed, 2007-16-05 at 15:12 -0700, Sridhar Samudrala wrote:
> Jamal,
>
> Here are some comments i have on your patch.
> See them inline.
>
Thanks for taking the time Sridhar.
> try_tx_pkts() is directly calling the device's batch xmit routine.
> Don't we need to call dev_hard_start_xmit() to handle dev_queue_xmit_nit
> and GSO segmentation?
>
I think this is the core of all your other comments.
Good catch - that piece of code has changed since 2.6.18; so the patch
i posted wont work with GSO.
You actually caught a bug in my other patch as well that nobody else
did;->
I will have to think a bit about this; i may end up coalescing when
grabbing the packets but call the nit from the driver using a helper.
cheers,
jamal
next prev parent reply other threads:[~2007-05-16 22:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OF0CAD6D87.DBE62968-ON872572DC.0073646A-882572DC.0073BEC2@us.ibm.com>
2007-05-15 21:17 ` [RFC] New driver API to speed up small packets xmits Roland Dreier
[not found] ` <OFF5654BB8.74EC8DCB-ON872572DC.00752079-882572DC.00756B23@us.ibm.com>
2007-05-15 21:25 ` Roland Dreier
[not found] ` <OF21D475A2.5E5C88DE-ON872572DC.00763DE4-882572DC.00768A7E@us.ibm.com>
2007-05-15 21:38 ` David Miller
2007-05-15 21:32 ` David Miller
2007-05-15 22:17 ` [WIP] [PATCH] WAS " jamal
2007-05-15 22:48 ` jamal
2007-05-16 0:50 ` jamal
2007-05-16 22:12 ` Sridhar Samudrala
2007-05-16 22:52 ` jamal [this message]
2007-05-17 3:25 ` jamal
2007-05-18 12:07 ` jamal
2007-05-17 4:03 ` Krishna Kumar2
2007-05-16 21:44 ` Sridhar Samudrala
2007-05-17 5:01 ` Krishna Kumar2
[not found] ` <OF6757F56D.EE5984FD-ON872572DC.0081026C-882572DC.00814B8F@us.ibm.com>
2007-05-15 23:36 ` David Miller
2007-05-21 7:56 ` Herbert Xu
[not found] ` <OF9ABCD08D.2CD1B193-ON872572E3.007A6FC1-882572E3.007ACE1A@us.ibm.com>
2007-05-22 22:36 ` David Miller
[not found] ` <OFCF3EB7F8.9740C0C7-ON872572E3.007DADF6-882572E3.007E0E7B@us.ibm.com>
2007-05-22 23:04 ` David Miller
2007-05-22 23:12 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179355932.4084.19.camel@localhost \
--to=hadi@cyberus.ca \
--cc=ak@suse.de \
--cc=ashwin.chaugule@celunite.com \
--cc=davem@davemloft.net \
--cc=gagan@vmware.com \
--cc=johnpol@2ka.mipt.ru \
--cc=krkumar2@in.ibm.com \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=sri@us.ibm.com \
--cc=xma@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.