All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] pata_sil680: compile fix
Date: Sun, 20 May 2007 06:57:33 +1000	[thread overview]
Message-ID: <1179608253.32247.481.camel@localhost.localdomain> (raw)
In-Reply-To: <464ED193.2020805@gmail.com>

On Sat, 2007-05-19 at 12:29 +0200, Tejun Heo wrote:
> Recent mmio change broke compilation if PM is turned on.  Fix it.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Oops.. sorry about that.

Cheers,
Ben.

> ---
>  pata_sil680.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_sil680.c b/drivers/ata/pata_sil680.c
> index 557a37b..89f59d1 100644
> --- a/drivers/ata/pata_sil680.c
> +++ b/drivers/ata/pata_sil680.c
> @@ -431,7 +431,9 @@ use_ioports:
>  #ifdef CONFIG_PM
>  static int sil680_reinit_one(struct pci_dev *pdev)
>  {
> -	sil680_init_chip(pdev);
> +	int try_mmio;
> +
> +	sil680_init_chip(pdev, &try_mmio);
>  	return ata_pci_device_resume(pdev);
>  }
>  #endif


  reply	other threads:[~2007-05-19 20:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-19 10:29 [PATCH] pata_sil680: compile fix Tejun Heo
2007-05-19 20:57 ` Benjamin Herrenschmidt [this message]
2007-05-22  0:02 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1179608253.32247.481.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.