All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Yi <yi.zhu@intel.com>
To: Michael Wu <flamingice@sourmilk.net>
Cc: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	Jiri Benc <jbenc@suse.cz>
Subject: Re: [PATCH 2/3] mac80211: IEEE802.11e/WMM TS management and DLS  support
Date: Thu, 24 May 2007 15:34:34 +0800	[thread overview]
Message-ID: <1179992075.6150.30.camel@debian.sh.intel.com> (raw)
In-Reply-To: <200705232342.31882.flamingice@sourmilk.net>

On Wed, 2007-05-23 at 23:42 -0700, Michael Wu wrote:
> The dls_info code looks like it was copied from the sta_info code and modified 
> to store what you need. No good.
> 
> Instead, you should modify struct sta_info to hold the information necessary. 

OK.

> > + if (dls_link_status(&sdata->u.sta, hdr.addr1) == DLS_STATUS_OK){
> How is this line suppose to work? I don't see hdr.addr1 initialized at any 
> point before this.

DLS must be setup before it can be used. The addr1 is inserted into the
dls hash table when the QSTA received a successful DLS response or
accepted a DLS request.

Thanks,
-yi

  reply	other threads:[~2007-05-24  7:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-14  5:15 [PATCH 2/3] mac80211: IEEE802.11e/WMM TS management and DLS support Zhu Yi
2007-05-24  6:42 ` Michael Wu
2007-05-24  7:34   ` Zhu Yi [this message]
2007-05-24  7:39     ` Michael Wu
2007-05-24  7:56       ` Zhu Yi
  -- strict thread matches above, loose matches on Subject: below --
2007-05-25 11:52 Zhu Yi
2007-06-06  8:22 Zhu Yi
2007-06-06 19:18 ` Johannes Berg
2007-06-11  4:11   ` Zhu Yi
2007-06-11  8:25     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1179992075.6150.30.camel@debian.sh.intel.com \
    --to=yi.zhu@intel.com \
    --cc=flamingice@sourmilk.net \
    --cc=jbenc@suse.cz \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.