Re: [bitbake-devel] [PATCH] add basic b4 config file

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Tim,

On 5/24/24 8:36 PM, Tim Orling via lists.openembedded.org wrote:
> On Fri, May 24, 2024 at 11:24 AM Tim Orling <ticotimo@gmail.com> wrote:
> 
>>
>>
>> On Fri, May 24, 2024 at 9:28 AM Khem Raj via lists.openembedded.org
>> <raj.khem=gmail.com@lists.openembedded.org> wrote:
>>
>>> On Fri, May 24, 2024 at 8:33 AM Quentin Schulz <quentin.schulz@cherry.de>
>>> wrote:
>>>>
>>>> Hi Khem,
>>>>
>>>> On 5/24/24 5:18 PM, Khem Raj via lists.openembedded.org wrote:
>>>>> On Fri, May 24, 2024 at 6:49 AM Quentin Schulz via
>>>>> lists.openembedded.org <foss=0leil.net@lists.openembedded.org> wrote:
>>>>>>
>>>>>> From: Quentin Schulz <quentin.schulz@cherry.de>
>>>>>>
>>>>>> b4[1] is a very nice tool for mail-based contribution. A config[2]
>>> file
>>>>>> exists to set up a few defaults. We can use it to set the Cc
>>> recipients
>>>>>> to always add, in our case the mailing list.
>>>>>>
>>>>>> This shouldn't be necessary if we had a script that b4 prep
>>> --auto-to-cc
>>>>>> could call to find the mail address(es) to send to. While we could do
>>>>>> that, this opens the door to people trying to add a way to notify
>>> some
>>>>>> people (e.g. a MAINTAINERS file) which is not somewhere the project
>>>>>> wants to go right now, and this also makes sure the address is always
>>>>>> added even if one forgets to run b4 prep --auto-to-cc (which is part
>>> of
>>>>>> the typical workflow for U-Boot and Linux kernel, but is not
>>> necessary
>>>>>> thanks to this patch).
>>>>>>
>>>>>> [1] https://pypi.org/project/b4/
>>>>>> [2] https://b4.docs.kernel.org/en/latest/config.html
>>>>>>
>>>>>> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
>>>>>> ---
>>>>>> This adds a basic config file for b4 to avoid to have to add the
>>> mailing
>>>>>> list by hand. For documentation patches, one will still need to run
>>>>>> b4 send --cc docs@lists.yoctoproject.org
>>>>>> manually for sending it to the docs ML as well.
>>>>>>
>>>>>> Note that b4 supports patchwork, c.f.
>>>>>>
>>> https://b4.docs.kernel.org/en/latest/config.html#patchwork-integration-settings
>>>>>> though I have no clue what it does with it as I am no maintainer, but
>>>>>> maybe something worth having a look at if some maintainer of this
>>> repo
>>>>>> wants to use b4 to merge stuff?
>>>>>
>>>>> I use b4 regularly for meta-openembedded maintenance and it also
>>> updates
>>>>> patchwork when patch is accepted, I have this config.
>>>>>
>>>>>      [b4]
>>>>>       pw-url = "https://patchwork.yoctoproject.org/"
>>>>>       pw-key = "<mykey>"
>>>>>       pw-project = "oe"
>>>>>       pw-review-state = "under-review"
>>>>>       pw-accept-state =  "accepted"
>>>>>       pw-discard-state = "rejected"
>>>>>       send-series-to = "openembedded-devel@lists.openembedded.org"
>>>
>>
>> This inspired me to revisit the issue I was having with "b4 shazam <
>> message.id for an AUH upgrade>", where
>> shazam would stumble because of the "scissors line" (--- >8 ---)
>>
>> Turns out the solution appears to be
>> [b4]
>>      stdin-pipe-sep = "--- >8 ---"
>>
> 
> Correction, where I was having trouble was with "git pw patch apply"
> 
> $ git pw patch apply 43726
> Failed to apply patch:
> hint: When you have resolved this problem, run "git am --continue".
> hint: If you prefer to skip this patch, run "git am --skip" instead.
> hint: To record the empty patch as an empty commit, run "git am
> --allow-empty".
> hint: To restore the original branch and stop patching, run "git am
> --abort".
> hint: Disable this message with "git config advice.mergeConflict false"
> Patch is empty.
> 
> Whereas "b4 shazam
> 0101018f7d589796-87eb5d6d-06ed-4275-b5bc-6bad87216833-000000@us-west-2.amazonses.com"
> works:
> 
> $ b4 shazam
> 0101018f7d589796-87eb5d6d-06ed-4275-b5bc-6bad87216833-000000@us-west-2.amazonses.com
> Grabbing thread from
> lore.kernel.org/all/0101018f7d589796-87eb5d6d-06ed-4275-b5bc-6bad87216833-000000@us-west-2.amazonses.com/t.mbox.gz
> Checking for newer revisions
> Grabbing search results from lore.kernel.org
> Analyzing 1 messages in the thread
> Checking attestation on all messages, may take a moment...
> Retrieving CI status, may take a moment...
> ---
>    ✓ [PATCH] nghttp2: upgrading to 1.62.0 SUCCEEDED
>    ---
>    ✓ Signed: DKIM/yoctoproject.org
> ---
> Total patches: 1
> ---
> Applying: nghttp2: upgrade 1.61.0 -> 1.62.0
> 
> 
> Any tricks to getting the Message-Id from patchwork?
> 

I assume you mean you want to use the patchwork id with b4 shazam?

In any case, you can send a mail on https://lore.kernel.org/tools/ with 
[b4] as prefix to ask for help or suggest something :)

Cheers,
Quentin