From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753583AbXEXU4m (ORCPT ); Thu, 24 May 2007 16:56:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751367AbXEXU4f (ORCPT ); Thu, 24 May 2007 16:56:35 -0400 Received: from adelie.ubuntu.com ([82.211.81.139]:44408 "EHLO adelie.ubuntu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbXEXU4f (ORCPT ); Thu, 24 May 2007 16:56:35 -0400 Subject: Re: [PATCH 4/6] RTC: Ratelimit "lost interrupts" message From: Ben Collins To: Andrew Morton Cc: linux-kernel@vger.kernel.org In-Reply-To: <20070524134822.ed020127.akpm@linux-foundation.org> References: <98cd38b5.git.bcollins@ubuntu.com> <20070524134822.ed020127.akpm@linux-foundation.org> Content-Type: text/plain Organization: Canonical Date: Thu, 24 May 2007 16:56:52 -0400 Message-Id: <1180040212.12570.279.camel@cunning> Mime-Version: 1.0 X-Mailer: Evolution 2.11.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2007-05-24 at 13:48 -0700, Andrew Morton wrote: > On Wed, 23 May 2007 18:23:06 -0400 > Ben Collins wrote: > > > Signed-off-by: Ben Collins > > --- > > drivers/char/rtc.c | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c > > index 20380a2..22cf7aa 100644 > > --- a/drivers/char/rtc.c > > +++ b/drivers/char/rtc.c > > @@ -1159,7 +1159,8 @@ static void rtc_dropped_irq(unsigned long data) > > > > spin_unlock_irq(&rtc_lock); > > > > - printk(KERN_WARNING "rtc: lost some interrupts at %ldHz.\n", freq); > > + if (printk_ratelimit()) > > + printk(KERN_WARNING "rtc: lost some interrupts at %ldHz.\n", freq); > > > > Presumably someone is getting a lot of these messages. > > Do we know why? Is there something which needs fixing here? I got it a lot when using any sort of virtualization on my Core2Duo (kvm, vmware, qemu). Just a big spew. Honestly, I was getting this with 2.6.20, and haven't tested again with latest kernel. -- Ubuntu : http://www.ubuntu.com/ Linux1394: http://wiki.linux1394.org/