From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
ulrich.weigand@de.ibm.com
Subject: Re: [RFC/PATCH 4/5] powerpc: Make syscall restart code more common
Date: Tue, 29 May 2007 21:41:25 +1000 [thread overview]
Message-ID: <1180438885.19517.157.camel@localhost.localdomain> (raw)
In-Reply-To: <20070529113232.GA6071@lst.de>
On Tue, 2007-05-29 at 13:32 +0200, Christoph Hellwig wrote:
> On Tue, May 29, 2007 at 04:45:23PM +1000, Benjamin Herrenschmidt
> wrote:
> > +static inline void check_syscall_restart(struct pt_regs *regs,
> > + struct k_sigaction *ka,
> > + int has_handler)
> > +{
>
> I don't think this should be inlined. Just create a new signal.c
> file,
> which can grow a lot more common signal code later on aswell.
I've been thinking about doing that too. In fact, some of the
ptrace-common.h stuff should probably be turned back into ptrace.c too
for the same reason. I'm still toying with that part of the designm but
yeah, I think that's something to do.
Ben.
next prev parent reply other threads:[~2007-05-29 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 6:45 [RFC/PATCH 4/5] powerpc: Make syscall restart code more common Benjamin Herrenschmidt
2007-05-29 11:32 ` Christoph Hellwig
2007-05-29 11:41 ` Benjamin Herrenschmidt [this message]
2007-05-29 13:30 ` Kumar Gala
2007-05-30 0:53 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180438885.19517.157.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=hch@lst.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=ulrich.weigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.