All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@XenSource.com>
To: Alex Williamson <alex.williamson@hp.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: Re: [Xen-staging] [xen-unstable] If we find a Linux repository in $(LINUX_SRC_PATH) then symlink it
Date: Tue, 05 Jun 2007 08:59:00 +0100	[thread overview]
Message-ID: <1181030340.4041.25.camel@localhost.localdomain> (raw)
In-Reply-To: <1181027480.5416.33.camel@cthulhu.hellion.org.uk>

On Tue, 2007-06-05 at 08:11 +0100, Ian Campbell wrote:
> On Mon, 2007-06-04 at 16:19 -0600, Alex Williamson wrote:
> 
> > You're cloning from a remote repo, mine is local on disk:
> 
> Ah yes, I see the problem now. I'll have a look at fixing it this
> morning.

Done, although not as clean as I had hoped.

# HG changeset patch
# User Ian Campbell <ian.campbell@xensource.com>
# Date 1181030273 -3600
# Node ID 23460646912e4ad627b30bc614045ee20a18233a
# Parent  7a16a499152ce67fb36b4e101b7d2d953d1f6362
BUILD: Clone the Linux tree if it wasn't found via $(LINUX_SRC_PATH)
even if it happens to be a local directory.

If we located the Linux tree by deriving the path from "hg path
default" and it is a local path then prepend "file://" to prevent us
trying to symlink it.

Unfortunately mercurial doesn't understand file:// URLs so we have to
strip it off again before calling hg clone.

Signed-off-by: Ian Campbell <ian.campbell@xensource.com>

diff -r 7a16a499152c -r 23460646912e buildconfigs/select-repository
--- a/buildconfigs/select-repository	Mon Jun 04 17:09:12 2007 +0100
+++ b/buildconfigs/select-repository	Tue Jun 05 08:57:53 2007 +0100
@@ -45,5 +45,14 @@ fi
 fi
 
 echo "$ME: Found ${BASE}/${REPO}" 1>&2
-echo ${BASE}/${REPO}
+
+# If ${BASE}/${REPO} is a local directory then prepend file:// so that
+# the test in src.hg-clone will fail and we will clone instead of
+# linking this repository. We only want to link repositories which
+# were found via LINUX_SRC_PATH.
+if [ -d "${BASE}/${REPO}" ] ; then
+    echo "file://${BASE}/${REPO}"
+else
+    echo ${BASE}/${REPO}
+fi
 exit 0
diff -r 7a16a499152c -r 23460646912e buildconfigs/src.hg-clone
--- a/buildconfigs/src.hg-clone	Mon Jun 04 17:09:12 2007 +0100
+++ b/buildconfigs/src.hg-clone	Tue Jun 05 08:57:53 2007 +0100
@@ -28,7 +28,7 @@ XEN_LINUX_HGREV  ?= tip
 	        ln -s $${__repo} $(LINUX_SRCDIR) ; \
 	    else \
 	        echo "Cloning $${__repo} to $(LINUX_SRCDIR)." ; \
-	        $(HG) clone $${__repo} $(LINUX_SRCDIR) ; \
+	        $(HG) clone $${__repo#file://} $(LINUX_SRCDIR) ; \
 	    fi ; \
 	else \
 	    __parent=$$($(HG) -R $(LINUX_SRCDIR) path default) ; \

  parent reply	other threads:[~2007-06-05  7:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200706041442.l54EgKQp007662@latara.uk.xensource.com>
2007-06-04 18:49 ` [Xen-staging] [xen-unstable] If we find a Linux repository in $(LINUX_SRC_PATH) then symlink it Alex Williamson
2007-06-04 21:37   ` Ian Campbell
2007-06-04 21:44     ` Alex Williamson
2007-06-04 22:03       ` Ian Campbell
2007-06-04 22:19         ` Alex Williamson
2007-06-05  7:11           ` Ian Campbell
2007-06-05  7:31             ` Re: [Xen-staging] [xen-unstable] If we find a Linuxrepository " Cui, Dexuan
2007-06-05  7:54               ` Ian Campbell
2007-06-05  8:29                 ` Re: [Xen-staging] [xen-unstable] If we find aLinuxrepository " Cui, Dexuan
2007-06-05 15:27                   ` Ian Campbell
2007-06-05  7:59             ` Ian Campbell [this message]
2007-06-05 14:21               ` Re: [Xen-staging] [xen-unstable] If we find a Linux repository " Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1181030340.4041.25.camel@localhost.localdomain \
    --to=ian.campbell@xensource.com \
    --cc=alex.williamson@hp.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.