All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Krzysztof Helt <krzysztof.h1@wp.pl>, linux-kernel@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] drivers/video/pm3fb.c: possible cleanups
Date: Tue, 05 Jun 2007 18:45:54 +0800	[thread overview]
Message-ID: <1181040354.5023.3.camel@daplas> (raw)
In-Reply-To: <20070604221257.GD5500@stusta.de>

On Tue, 2007-06-05 at 00:12 +0200, Adrian Bunk wrote:
> This patch contains the following possible cleanups:

> -
> -int __init pm3fb_init(void)
> -{
> -	/*
> -	 *  For kernel boot options (in 'video=pm3fb:<options>' format)
> -	 */
> -#ifndef MODULE
> -	char *option = NULL;
> -
> -	if (fb_get_options("pm3fb", &option))
> -		return -ENODEV;

The cleanup is good, but we should still leave the above with
the second parameter as NULL so the driver can also listen to
global options, such as video=pm3fb:off.

I'll fix this up. Thanks.

Krzysztof,

I think this patch is okay.  If you need to add an option parser
for your driver, you can always add this in the future.

Tony



  reply	other threads:[~2007-06-05 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-04 22:12 [RFC: 2.6 patch] drivers/video/pm3fb.c: possible cleanups Adrian Bunk
2007-06-05 10:45 ` Antonino A. Daplas [this message]
2007-06-06 15:40   ` Krzysztof Helt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1181040354.5023.3.camel@daplas \
    --to=adaplas@gmail.com \
    --cc=bunk@stusta.de \
    --cc=krzysztof.h1@wp.pl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.