From: Joe Perches <joe@perches.com>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: netdev@vger.kernel.org, jeff@garzik.org, davem@davemloft.net,
arjan@linux.intel.com, shemminger@linux-foundation.org
Subject: Re: [PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family
Date: Mon, 11 Jun 2007 15:24:45 -0700 [thread overview]
Message-ID: <1181600685.6020.20.camel@localhost> (raw)
In-Reply-To: <466DC657.2030401@intel.com>
On Mon, 2007-06-11 at 15:01 -0700, Kok, Auke wrote:
> > msg_enable is more frequently defined in drivers/net as u32 not int.
> yes, we're only using the bottom 15 bits anyway, but the net_device struct
> consistently uses 'int' style members, leaving it up to the compiler to pick an
> appropriate size for each arch. That was the reason I chose int here.
I guess I'm from a "don't be larger than necessary" school.
As it's a bitfield and not a boolean, it should be unsigned.
Perhaps it could also be a good time to rename it to something
like netif_enabled_msgs?
next prev parent reply other threads:[~2007-06-11 22:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-11 21:37 [PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family Auke Kok
2007-06-11 21:37 ` [PATCH 2/2] [RFC] NET: Convert several drivers to ndev_printk Auke Kok
2007-06-11 21:52 ` [PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family Kok, Auke
2007-06-11 21:54 ` Joe Perches
2007-06-11 22:01 ` Kok, Auke
2007-06-11 22:24 ` Joe Perches [this message]
2007-06-11 22:00 ` Randy Dunlap
2007-06-11 22:04 ` Kok, Auke
2007-06-11 22:19 ` Stephen Hemminger
2007-06-11 22:43 ` Kok, Auke
-- strict thread matches above, loose matches on Subject: below --
2007-06-08 22:00 Auke Kok
2007-06-08 23:24 ` Stephen Hemminger
2007-06-08 23:42 ` Kok, Auke
2007-06-09 0:10 ` Stephen Hemminger
2007-06-09 3:06 ` Kok, Auke
2007-06-09 3:18 ` Kok, Auke
2007-06-11 17:30 ` Kok, Auke
2007-06-11 17:50 ` Stephen Hemminger
2007-06-11 18:28 ` Joe Perches
2007-06-11 20:28 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181600685.6020.20.camel@localhost \
--to=joe@perches.com \
--cc=arjan@linux.intel.com \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.