From: Zhu Yi <yi.zhu@intel.com>
To: Jiri Benc <jbenc@suse.cz>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 2/6] mac80211: remove global tsinfo debugfs variables
Date: Wed, 13 Jun 2007 14:03:05 +0800 [thread overview]
Message-ID: <1181714585.4758.64.camel@debian.sh.intel.com> (raw)
In-Reply-To: <20070612133608.5f6e9b60@logostar.upir.cz>
On Tue, 2007-06-12 at 13:36 +0200, Jiri Benc wrote:
> Johannes probably meant a binary blob prepared by user space. That still
> complies to the one value per file rule.
Right, but that is not easy to use (i.e with `echo` or `cat`) without
writting a user space program.
> > The DLS is easier because it only has one parameter (peer mac address)
> > now. I programed it the same way as tspec. So when we find to need more
> > parameters for DLS setup, we can add another debugfs file for the new
> > parameter instead of combining multiple parameters in one file.
> >
> > I'd agree I didn't pay a lot of attentions to the debugfs interface
> > design since I thought it was used for occasional debug only. Please
> > tell me what which do you prefer: one value per file or multiple values
> > per file so that we can do one shot parameter passing? So I don't need
> > to switch them back and forth.
>
> Depends on how long you want to keep this debugfs interface. If it's just a
> few months matter and it's never going to hit vanilla, it's probably not
> worth the effort to rewrite it.
I'm working with Johannes with the API define. When this is done,
hopfully we can remove the debugfs stuff.
Thanks,
-yi
prev parent reply other threads:[~2007-06-13 6:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 17:03 [PATCH 2/6] mac80211: remove global tsinfo debugfs variables Zhu Yi
2007-06-08 19:42 ` Johannes Berg
2007-06-11 2:57 ` Zhu Yi
2007-06-11 8:21 ` Johannes Berg
2007-06-12 11:36 ` Jiri Benc
2007-06-13 6:03 ` Zhu Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181714585.4758.64.camel@debian.sh.intel.com \
--to=yi.zhu@intel.com \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.