All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Help!  Need to add a flag to ia64 thread flags
Date: Wed, 13 Jun 2007 17:02:04 +0000	[thread overview]
Message-ID: <1181754124.6148.37.camel@localhost> (raw)

Stephane:

I need to add a flag to the ia64 thread info flags to support my
automigration work.  I was using TIF_NOTIFY_RESUME which you removed.  I
didn't notice that happening, but even if I did, I couldn't/wouldn't
have objected because my patches are still [maybe always?] out of tree.

Now, I've tried to add an automigration-specific flag, called
TIF_MIGRATION_WORK--to the flags to trigger entry to do_notify_resume()
to handle auto-migration.  However, I'm getting errors from the
assembler in arch/ia64/kernel/fsys.S where ever the instruction:

	and r?=TIF_ALLWORK_MASK,r?

occurs, complaining that "Operand 2 of 'and' should be an 8-bit integer
(-128-127)".  This is worrisome to begin with, as thread information
flags comment says that "pending work-to-be-done flags are in
least-significant 16 bits", while the code currently only supports
"8-bits".  What's more interesting is that I've used bit '7' for the
TIF_MIGRATION_WORK flag.  That should fit in the range (-128 - 127),
right?  Maybe the assembler is confused by sign extension of the signed
8-bit int?

For my testing, I can probably use your 'PERFMON_WORK flag, but that's
probably not a good long term solution.  Any ideas how to proceed longer
term to support >7 pending work flags?

Lee


             reply	other threads:[~2007-06-13 17:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13 17:02 Lee Schermerhorn [this message]
2007-06-13 17:21 ` Help! Need to add a flag to ia64 thread flags Stephane Eranian
2007-07-27  0:01   ` Re:[PATCH] Fix uninitialized local variable "covered" in i386 acpi-cpufreq driver Fenghua Yu
2007-07-26 23:46 ` [PATCH] " Fenghua Yu
2007-07-27  0:12   ` Andrew Morton
2007-07-27  0:16     ` Andrew Morton
2007-07-27  0:46       ` Yu, Fenghua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1181754124.6148.37.camel@localhost \
    --to=lee.schermerhorn@hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.