From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [RFC][ASoC] New device/driver arch Date: Fri, 15 Jun 2007 16:36:38 +0100 Message-ID: <1181921798.26658.77.camel@localhost.localdomain> References: <1181842832.26658.42.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource.wolfsonmicro.com (unknown [80.75.67.54]) by alsa0.perex.cz (Postfix) with ESMTP id B798D103890 for ; Fri, 15 Jun 2007 17:36:40 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Seth Forshee Cc: Takashi Iwai , alsa-devel , Timur Tabi , Nobin Mathew List-Id: alsa-devel@alsa-project.org On Fri, 2007-06-15 at 10:01 -0500, Seth Forshee wrote: > Hi Liam, > > On 6/14/07, Liam Girdwood wrote: > > > Example machine driver for Mainstone with WM8753 is here :- > > > > http://opensource.wolfsonmicro.com/cgi-bin/gitweb/gitweb.cgi?p=linux-2.6-asoc;a=blob;f=sound/soc/pxa/mainstone_wm8753.c;h=a49c1c528063494aeadee26ea3e07405c3a8762e;hb=ppc-dev > > > > The machine driver now also does the I2C/SPI probing (instead of the > > codec) and also does any codec IO (to better support multiple > > controllers). > > > > The way in which the platform device is created in this file seems to > have a problem. The mainstone_wm8753_probe() function (along > everything else after that point) seems to expect that the platform > device will be encapsulated in a struct snd_soc_machine, but this > doesn't seem to be the case since you are instantiating the device > with platform_driver_probe(). Am I missing something? Your right. This is a bug. Will fix. Thanks Liam