From: Richard Hughes <hughsient@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-acpi <linux-acpi@vger.kernel.org>,
a_bartok@freemail.hu, Bastien Nocera <hadess@hadess.net>,
David Zeuthen <david@fubar.dk>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] Reporting the lid status using INPUT
Date: Sat, 16 Jun 2007 18:11:51 +0100 [thread overview]
Message-ID: <1182013911.2309.4.camel@work> (raw)
In-Reply-To: <1181919208.2681.6.camel@work>
On Fri, 2007-06-15 at 15:53 +0100, Richard Hughes wrote:
> On Fri, 2007-06-15 at 10:29 -0400, Dmitry Torokhov wrote:
> > On 6/15/07, Richard Hughes <hughsient@gmail.com> wrote:
> > > On Fri, 2007-06-15 at 13:29 +0100, Richard Hughes wrote:
> > > > in response to an event, but I'm thinking in a resume hook we should
> > > > probably do acpi_evaluate_integer(handle, "_LID", NULL, &state) and then
> > > > send an event, just so userspace is aware of what the state of the panel
> > > > is.
> > >
> > > Attached patch fixed the issue for me. Comments?
> > >
> >
> > The patch makes perfect sense. The only issue I have is this:
> >
> > > + /* on resume we send the state; it might be the same, but userspace
> > > + * should handle duplicated events */
> >
> > If switch state matches to what input layer thinks it is the event
> > will not even reach userspace.
>
> Okay, new patch attached, thanks for the speedy review.
This fix is also confirmed by somebody else, see
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243030
It would be great if this could go into .22, although I appreciate it's
quite late in the day.
Richard.
next prev parent reply other threads:[~2007-06-16 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 12:29 Reporting the lid status using INPUT Richard Hughes
2007-06-15 13:12 ` [patch] " Richard Hughes
2007-06-15 14:29 ` Dmitry Torokhov
2007-06-15 14:53 ` Richard Hughes
2007-06-16 17:11 ` Richard Hughes [this message]
2007-06-16 17:51 ` Dmitry Torokhov
2007-06-24 22:06 ` GMail
2007-06-25 20:49 ` Bartók Albert
2007-06-25 21:24 ` Richard Hughes
2007-06-25 21:24 ` Richard Hughes
2007-06-27 19:42 ` Richard Hughes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1182013911.2309.4.camel@work \
--to=hughsient@gmail.com \
--cc=a_bartok@freemail.hu \
--cc=david@fubar.dk \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.