Re: [PATCH 03/17] mkfs: Sanitise the superblock feature macros

From: Jan Tulak <jtulak@redhat.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com, Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH 03/17] mkfs: Sanitise the superblock feature macros
Date: Fri, 3 Jul 2015 05:53:27 -0400 (EDT)	[thread overview]
Message-ID: <118220992.23297038.1435917207418.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20150625193807.GG36162@bfoster.bfoster>

----- Original Message -----
> From: "Brian Foster" <bfoster@redhat.com>
> > @@ -1912,17 +2013,17 @@ _("32 bit Project IDs always enabled on CRC enabled
> > filesytems\n"));
> >  		 * tried to use crc=0,finobt=1, then issue a warning before
> >  		 * turning them off.
> >  		 */
> > -		if (finobt && finobtflag) {
> > +		if (sb_feat.finobt && sb_feat.finobtflag) {
> 
> Since the code above drops finobtflag, I don't think we'll ever hit
> this. Indeed, I can now create a crc=0,finobt=1 fs, which shouldn't
> happen.
> 
> Brian
> 

Finobtflag is dropped by a later patch in the set entirely. After all patches, the line is:

	if (sb_feat.finobt && mopts.subopt_params[M_FINOBT].seen)

Which indeed works as it should:

mkfs.xfs -f -m crc=0,finobt=1 /dev/vdb2
warning: finobt not supported without CRC support, disabled.

Cheers,
Jan

-- 
Jan Tulak
jtulak@redhat.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs