From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH 4/4] Add libvdisk, and vdisk_tool
Date: Tue, 19 Jun 2007 17:10:03 +0100
Message-ID: <1182269404.22186.5.camel@blaa>
References: <4677D739.3010800@virtualiron.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4677D739.3010800@virtualiron.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ben Guthro <bguthro@virtualiron.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Hi Ben,

On Tue, 2007-06-19 at 09:16 -0400, Ben Guthro wrote:

> diff -r 7cad1f06a7f6 tools/vdisk/vdisk_common.c

...

> +       if (vdisk->use_aio) {

...

> +               vdisk->ioctx = (io_context_t) REQUEST_ASYNC_FD;   
> +               vdisk->aio_fd = io_setup(VDISK_HASH_SZ, &vdisk->ioctx);
> +               if (vdisk->aio_fd < 0) {
> +                       VIDDBG(0, "io_setup can't get async poll ID (%s). "
> +                              " Async IO will not be available\n",
> +                               strerror(errno));
> +                       vdisk->use_aio = 0;             
> +               }

	Note that the aio and qcow blktap drivers now use the tapaio wrapper to
poll on aio events, so it'd be nice if this code did the same.

	Since the aio code isn't used by qemu, perhaps it'd be better to move
it out of libvdisk and into blktap?

Cheers,
Mark.