From: Dave Hansen <hansendc@us.ibm.com>
To: Joel Schopp <jschopp@austin.ibm.com>
Cc: Andy Whitcroft <apw@shadowen.org>, Andrew Morton <akpm@osdl.org>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.06
Date: Fri, 22 Jun 2007 11:02:10 -0700 [thread overview]
Message-ID: <1182535330.26162.50.camel@localhost> (raw)
In-Reply-To: <467C0CE9.5010502@austin.ibm.com>
On Fri, 2007-06-22 at 12:54 -0500, Joel Schopp wrote:
> If it is "kinda like a mini function" why not make it "actually a mini
> function" and call it?
Several of our on-disk filesystems have an ioctl function that already
has indented goto labels. I don't think it's quite worth churning all
of these (working) filesystems to make a style checker happy.
I think it's worse style to be mixing label indentation in a file as it
is to create new "correct" indentation labels. That's why I suggested
using context in the file to determine it rather than absolute rules.
-- Dave
next prev parent reply other threads:[~2007-06-22 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 8:45 [PATCH] update checkpatch.pl to version 0.06 Andy Whitcroft
2007-06-22 17:09 ` Dave Hansen
2007-06-22 17:54 ` Joel Schopp
2007-06-22 18:02 ` Dave Hansen [this message]
2007-06-22 18:17 ` Joel Schopp
2007-06-22 19:16 ` Theodore Tso
2007-06-23 4:04 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1182535330.26162.50.camel@localhost \
--to=hansendc@us.ibm.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.