Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

[David Howells <dhowells@redhat.com>]

Zach Brown <zab@zabbo.net> wrote:

> /* haha, continuing the fine tradition of terrible names in this  api..  */
> static inline void *PTR_PTR(void *err_ptr) {
> 	BUG_ON(!IS_ERR(err_ptr) || !err_ptr);
> 	return err_ptr;
> }

How about ERR_CAST() instead?  Or maybe CAST_ERR()?

	struct dentry *blah(...)
	{
		struct inode *inode;

		inode = thing(...);
		if (IS_ERR(inode))
			return ERR_CAST(inode);
	}

Where ERR_CAST is defined as:

	static inline void *ERR_CAST(const void *error)
	{
		return (void *) x;
	}

David