From: "Phil Endecott" <phil_lftzl_endecott@chezphil.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] Add temperature-tracking mode to
Date: Tue, 26 Jun 2007 21:50:40 +0000 [thread overview]
Message-ID: <1182894640566@dmwebmail.belize.chezphil.org> (raw)
In-Reply-To: <1182682179001@dmwebmail.belize.chezphil.org>
Jean Delvare wrote:
>> --- linux-2.6-2.6.21/drivers/hwmon/f71805f.c.orig 2007-06-16 00:10:54.000000000 +0100
>> +++ linux-2.6-2.6.21/drivers/hwmon/f71805f.c 2007-06-19 21:07:26.000000000 +0100
[snip]
>> @@ -931,6 +1029,58 @@
>> show_pwm_freq, set_pwm_freq, 2);
>> static SENSOR_DEVICE_ATTR(pwm3_mode, S_IRUGO, show_pwm_mode, NULL, 2);
>>
>> +static SENSOR_DEVICE_ATTR(pwm1_auto_channels_temp, S_IRUGO,
>> + show_pwm_auto_channels, NULL, 0);
>> +static SENSOR_DEVICE_ATTR(pwm2_auto_channels_temp, S_IRUGO,
>> + show_pwm_auto_channels, NULL, 1);
>> +static SENSOR_DEVICE_ATTR(pwm3_auto_channels_temp, S_IRUGO,
>> + show_pwm_auto_channels, NULL, 2);
>> +static SENSOR_DEVICE_ATTR(pwm1_auto_channels_fan, S_IRUGO,
>> + show_pwm_auto_channels, NULL, 0);
>> +static SENSOR_DEVICE_ATTR(pwm2_auto_channels_fan, S_IRUGO,
>> + show_pwm_auto_channels, NULL, 1);
>> +static SENSOR_DEVICE_ATTR(pwm3_auto_channels_fan, S_IRUGO,
>> + show_pwm_auto_channels, NULL, 2);
>
> Not sure what others think about this (Mark? Juerg?) but this (pwm1 to
> fan1 and to temp1, etc.) seems to be the usual mapping for chips where
> the mappings can't be changed, so I wonder what's the benefit of
> creating read-only sysfs files to express it. I think I'd be just as
> happy with no channel files at all (and it's cheaper.) No strong
> opinion though.
If anyone would like to express an opinion on this please do so as soon
as possible. The hardware on which I am able to test this will soon
become unavailable.
Phil.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2007-06-26 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-24 10:49 [lm-sensors] [PATCH] Add temperature-tracking mode to Phil Endecott
2007-06-25 22:37 ` Phil Endecott
2007-06-26 21:50 ` Phil Endecott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1182894640566@dmwebmail.belize.chezphil.org \
--to=phil_lftzl_endecott@chezphil.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.