From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Wed, 27 Jun 2007 04:02:26 +0100
Subject: [Cluster-devel] [GFS2 PATCH 1/3] Obtaining no_formal_ino from
	directory entry
In-Reply-To: <4680688D.6060608@redhat.com>
References: <4680688D.6060608@redhat.com>
Message-ID: <1182913346.3665.3.camel@localhost.localdomain>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

On Mon, 2007-06-25 at 21:14 -0400, S. Wendy Cheng wrote:
> GFS2 lookup code doesn't ask for inode shared glock. This implies during 
> in-memory inode creation for existing file, GFS2 will not disk-read in 
> the inode contents. This leaves no_formal_ino un-initialized during 
> lookup time. The un-initialized no_formal_ino is subsequently encoded 
> into file handle. Clients will get ESTALE error whenever it tries to 
> access these files.
> 
> -- Wendy
> 

Generally this looks good. Please don't add back the _host structure
though - just add an extra no_formal_ino argument to the lookup function
which is a u64,

Steve.