All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, ravi1.kumar@amd.com,
	g.singh@nxp.com, hemant.agrawal@nxp.com, akhil.goyal@nxp.com,
	johndale@cisco.com, hyonkim@cisco.com, jingjing.wu@intel.com,
	wenzhuo.lu@intel.com, rmody@marvell.com, shshaikh@marvell.com,
	matan@mellanox.com, shahafs@mellanox.com,
	declan.doherty@intel.com, cristian.dumitrescu@intel.com,
	Kevin Traynor <ktraynor@redhat.com>
Subject: Re: [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning
Date: Wed, 25 Mar 2020 15:18:47 +0100	[thread overview]
Message-ID: <11831469.VsHLxoZxqI@xps> (raw)
In-Reply-To: <20200325141137.7088-1-ktraynor@redhat.com>

25/03/2020 15:11, Kevin Traynor:
> This is a blunt way to remove this warning.
> 
> Some alternatives are:
> - disable the warning for individual components
> - components rework to statically allocate memory for parts of structs impacted
> 
> Maybe there's some other solutions?

In general, I am against disabling warnings, neither globally nor specifically.
Is there a way to hide false positives without disabling the warning?

> Impacted components:
> ../drivers/crypto/caam_jr/caam_jr_pvt.h
> ../drivers/crypto/ccp/ccp_crypto.h
> ../drivers/crypto/dpaa_sec/dpaa_sec.h
> ../drivers/crypto/virtio/virtio_cryptodev.h
> ../drivers/net/enic/base/vnic_dev.c
> ../drivers/net/iavf/../../common/iavf/virtchnl.h
> ../drivers/net/ice/base/ice_adminq_cmd.h
> ../drivers/net/mlx4/mlx4_rxtx.c
> ../drivers/net/qede/base/ecore_mcp.c
> ../lib/librte_cryptodev/rte_cryptodev.h
> ../lib/librte_pipeline/rte_table_action.c
> 
> Full details in the Bugzilla:
> https://bugs.dpdk.org/show_bug.cgi?id=421

Would be easier to provide explanations here.
I think we need at least one false positive example.

> Kevin Traynor (2):
>   meson: gcc 10 disable stringop-overflow warnings
>   mk: gcc 10 disable stringop-overflow warnings

You don't need to split in 2 patches.




  parent reply	other threads:[~2020-03-25 14:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 14:11 [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning Kevin Traynor
2020-03-25 14:11 ` [dpdk-dev] [RFC 1/2] meson: gcc 10 disable stringop-overflow warnings Kevin Traynor
2020-03-25 14:11 ` [dpdk-dev] [RFC 2/2] mk: " Kevin Traynor
2020-03-25 14:18 ` Thomas Monjalon [this message]
2020-03-31 14:08   ` [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning Kevin Traynor
2020-03-31 14:53     ` Stephen Hemminger
2020-04-01 11:33       ` Kevin Traynor
2020-04-07 16:27 ` [dpdk-dev] [PATCH] build: gcc 10 disable stringop-overflow warnings Kevin Traynor
2020-04-10 10:51   ` Kevin Traynor
2020-04-10 13:23     ` Bruce Richardson
2020-04-16 18:43       ` Kevin Traynor
2020-04-16 18:45   ` [dpdk-dev] [PATCH v2] x86/eal: gcc 10 ignore " Kevin Traynor
2020-04-17  9:33     ` Bruce Richardson
2020-04-17 10:13       ` Thomas Monjalon
2020-04-17 14:50         ` Kevin Traynor
2020-04-17 12:40       ` Kevin Traynor
2020-04-17 15:43     ` [dpdk-dev] [PATCH v3] " Kevin Traynor
2020-05-06  9:20       ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11831469.VsHLxoZxqI@xps \
    --to=thomas@monjalon.net \
    --cc=akhil.goyal@nxp.com \
    --cc=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=g.singh@nxp.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hyonkim@cisco.com \
    --cc=jingjing.wu@intel.com \
    --cc=johndale@cisco.com \
    --cc=ktraynor@redhat.com \
    --cc=matan@mellanox.com \
    --cc=ravi1.kumar@amd.com \
    --cc=rmody@marvell.com \
    --cc=shahafs@mellanox.com \
    --cc=shshaikh@marvell.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.