From: Tom Zanussi <zanussi@us.ibm.com>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: linux-kernel@vger.kernel.org, dwilder@us.ibm.com, HOLZHEU@de.ibm.com
Subject: Re: [RFC PATCH 4/6] relay: add relay_reserve_cpu()
Date: Thu, 05 Jul 2007 11:00:35 -0500 [thread overview]
Message-ID: <1183651235.4517.166.camel@ubuntu> (raw)
In-Reply-To: <20070704031738.GB24341@Krystal>
On Tue, 2007-07-03 at 23:17 -0400, Mathieu Desnoyers wrote:
> * Tom Zanussi (zanussi@us.ibm.com) wrote:
> > This patch adds the ability to explicitly specify the per-cpu buffer
> > to reserve space in. Needed for early DTI tracing.
> >
>
> This should come with the ability to tell relay where the already
> allocated static buffers are. Can you tell me a little more on why the
> standard relay_reserve would not do the job? Is smp_processor_id() not
> ready to output a sensible CPU id yet ?
>
In the case of early tracing, the DTI code uses a global buffer and
saves the cpuid along with each event. Later, when the relay channel is
available, the relogging code wants to put each event in the appropriate
per-cpu relay buffer. The standard relay_reserve() always uses the
current cpuid, rather than the cpuid attached to the event, which is not
what we want. relay_reserve_cpu() simply allows a cpuid other than the
current one to be used.
Tom
prev parent reply other threads:[~2007-07-05 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-30 3:24 [RFC PATCH 4/6] relay: add relay_reserve_cpu() Tom Zanussi
2007-07-04 3:17 ` Mathieu Desnoyers
2007-07-05 16:00 ` Tom Zanussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183651235.4517.166.camel@ubuntu \
--to=zanussi@us.ibm.com \
--cc=HOLZHEU@de.ibm.com \
--cc=compudj@krystal.dyndns.org \
--cc=dwilder@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.