From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1I8MIQ-0003ql-Hd for mharc-grub-devel@gnu.org; Tue, 10 Jul 2007 16:26:54 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I8MIP-0003qb-Op for grub-devel@gnu.org; Tue, 10 Jul 2007 16:26:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I8MIO-0003qK-8G for grub-devel@gnu.org; Tue, 10 Jul 2007 16:26:52 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I8MIO-0003qH-3i for grub-devel@gnu.org; Tue, 10 Jul 2007 16:26:52 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I8MIN-0007Nk-Lv for grub-devel@gnu.org; Tue, 10 Jul 2007 16:26:51 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e1.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l6AKQmsg006965 for ; Tue, 10 Jul 2007 16:26:48 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l6AKQmrX558320 for ; Tue, 10 Jul 2007 16:26:48 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l6AKQmJO005686 for ; Tue, 10 Jul 2007 16:26:48 -0400 Received: from [9.41.46.187] (basalt-009041046187.austin.ibm.com [9.41.46.187]) by d01av04.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l6AKQluB005667 for ; Tue, 10 Jul 2007 16:26:48 -0400 From: Hollis Blanchard To: The development of GRUB 2 In-Reply-To: <20070709150550.GA13390@aragorn> References: <20070709150550.GA13390@aragorn> Content-Type: text/plain Date: Tue, 10 Jul 2007 15:26:43 -0500 Message-Id: <1184099203.9495.70.camel@basalt> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit X-detected-kernel: Linux 2.4-2.6 Subject: Re: GRUB_IEEE1275_FLAG_NO_PARTITION_0 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2007 20:26:53 -0000 On Mon, 2007-07-09 at 17:05 +0200, Robert Millan wrote: > What's the point of GRUB_IEEE1275_FLAG_NO_PARTITION_0 ? We have code that > checks this flag, but nobody initialises it: > > disk/ieee1275/ofdisk.c: if (! grub_ieee1275_test_flag (GRUB_IEEE1275_FLAG_NO_PARTITION_0)) > include/grub/ieee1275/ieee1275.h: GRUB_IEEE1275_FLAG_NO_PARTITION_0, In IEEE1275, partition 0 (as in "disk:0") means "the whole disk". However, CodeGen-based firmware (that means Genesi) have a bug where partition 0 is actually disk partition 1. In that case, to access the whole disk, GRUB must open "disk" instead of "disk:0". I have no idea how the initialization got lost; it should be initialized in the same place that the other flags are. Checking cvs history may be in order. -Hollis