Re: [RFC] Palms commits.

[Richard Purdie <rpurdie@rpsys.net>]

Hi,

On Tue, 2007-07-10 at 19:45 +0400, Sergey Lapin wrote: 
> I just had raging argument with Paul Sokolovsky about my commits,
> so I'd like to RFC them, and also I'd like to ask if all these changes
> should be passed through RFC.
> 
> Please, see attachments. Sorry for post-factum.

I looked at the attachment and it does give me cause for concern.

What's missing from your email is a clear piece of text saying why
you're making the changes you are. Your commits are also a bit confused.
Updating a kernel defconfig in "Palm Zire 72 machine update" isn't very
obvious.

As for comments on specific things in the patch, in principle I agree
with common machine files and kernel updates. The
MACHINE_EXTRA_RRECOMMENDS in the patch looks horrendous however and it
does go against the principles of task-base and friends. 

Problems with the MACHINE_EXTRA_RRECOMMENDS include:

* the modules should have dependency information which removes the need
for all sound modules to be listed for example, you only need the ones
at the tips of the chains.
* duplication with entries already in task-base

The module_autoload statements also look scary. Is the device totally
incapable of loading some of them for itself? I know for a fact you
don't need all the sound ones.

Regards,

Richard