From: Tom Tucker <tom@opengridcomputing.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: nfs@lists.sourceforge.net
Subject: Re: [RFC, PATCH 20/20] knfsd: create listener via portlist write
Date: Tue, 10 Jul 2007 20:04:15 -0500 [thread overview]
Message-ID: <1184115855.30033.98.camel@trinity.ogc.int> (raw)
In-Reply-To: <1184110606.6480.44.camel@heimdal.trondhjem.org>
[...snip...]
> > + /* This implements the ability to add a transport by writing
> > + * it's transport name to the portlist file
> > + */
> > + if (isalnum(buf[0])) {
> > + int err;
> > + char transport[16];
> > + int port;
> > + sscanf(buf, "%15s %4d", transport, &port);
>
> Hmm... This looks dodgy to me. You are not initialising transport and
> port nor even checking the return value of sscanf()?
>
Agreed, lazy code, but I think all I should do here is check that sscanf
got two parameters that met the format spec, i.e. no need to initialize
the port and transport variables.
> > + err = nfsd_create_serv();
> > + if (!err)
> > + err = svc_create_svcsock(nfsd_serv,
> > + transport, port,
> > + SVC_SOCK_ANONYMOUS);
> > + return err < 0 ? err : 0;
> > + }
> > +
> > return -EINVAL;
> > }
> >
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > NFS maillist - NFS@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/nfs
>
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-07-11 1:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 5:27 [RFC,PATCH 00/20] svc: sunrpc server side transport switch Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 01/20] svc: Add svc_sock_ops Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 02/20] svc: sko_detach and sko_free Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 03/20] svc: svc_prep_reply_hdr Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 04/20] svc: sko_has_wspace Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 05/20] svc: svc_max_payload Tom Tucker
2007-07-10 5:34 ` [RFC, PATCH 06/20] svc: export svc_sock_enqueue, svc_sock_received Tom Tucker
2007-07-10 23:08 ` Trond Myklebust
2007-07-11 0:45 ` Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 07/20] svc: centralise close handling Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 08/20] svc: centralise accept handling Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 09/20] svc: Add SK_LISTENER sock flag Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 10/20] svc: Add generic refcount services Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 11/20] svc: cleanup svc_sock initialization Tom Tucker
2007-07-10 5:34 ` [RFC, PATCH 12/20] scv: Create transport neutral debug bit RPCDBG_SVCTRANS Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 13/20] svc: Add svc_[un]register_transport Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 14/20] svc: Register TCP/UDP Transports Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 15/20] svc: transport file implementation Tom Tucker
2007-07-10 23:30 ` Trond Myklebust
2007-07-10 5:34 ` [RFC,PATCH 16/20] svc: sko_create_svc Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 17/20] svc: Add sko_get_name service Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 18/20] svc: Add sko_defer routine Tom Tucker
2007-07-10 5:35 ` [RFC,PATCH 19/20] knfsd: call svc_create_svcsock Tom Tucker
2007-07-10 23:32 ` Trond Myklebust
2007-07-11 0:48 ` Tom Tucker
2007-07-11 0:59 ` Tom Tucker
2007-07-10 5:35 ` [RFC,PATCH 20/20] knfsd: create listener via portlist write Tom Tucker
2007-07-10 23:36 ` [RFC, PATCH " Trond Myklebust
2007-07-11 1:04 ` Tom Tucker [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-08-20 16:20 [RFC,PATCH 00/20] svc: Server Side Transport Switch Tom Tucker
2007-08-20 16:24 ` [RFC,PATCH 20/20] knfsd: create listener via portlist write Tom Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184115855.30033.98.camel@trinity.ogc.int \
--to=tom@opengridcomputing.com \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.