From: muli@il.ibm.com
To: ak@suse.de
Cc: linux-kernel@vger.kernel.org, muli@il.ibm.com, jdmason@kudzu.us
Subject: [PATCH 1/4] x86-64: Calgary - fix few style problems pointed out by checkpatch.pl
Date: Wed, 11 Jul 2007 16:35:11 +0300 [thread overview]
Message-ID: <11841609141802-git-send-email-muli@il.ibm.com> (raw)
In-Reply-To: <11841609143732-git-send-email-muli@il.ibm.com>
From: Muli Ben-Yehuda <muli@il.ibm.com>
No actual code was harmed in the production of this patch.
Thanks to Andrew Morton <akpm@linux-foundation.org> for telling me
about checkpatch.pl.
Signed-off-by: Muli Ben-Yehuda <muli@il.ibm.com>
---
arch/x86_64/kernel/pci-calgary.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/arch/x86_64/kernel/pci-calgary.c b/arch/x86_64/kernel/pci-calgary.c
index aef4cfc..f589c2d 100644
--- a/arch/x86_64/kernel/pci-calgary.c
+++ b/arch/x86_64/kernel/pci-calgary.c
@@ -377,7 +377,9 @@ static inline struct iommu_table *find_iommu_table(struct device *dev)
pbus = pdev->bus;
tbl = pbus->self->sysdata;
- BUG_ON(pdev->bus->parent && (tbl->it_busno != pdev->bus->parent->number));
+
+ BUG_ON(pdev->bus->parent &&
+ (tbl->it_busno != pdev->bus->parent->number));
return tbl;
}
@@ -943,7 +945,8 @@ static void calioc2_dump_error_regs(struct iommu_table *tbl)
/* dump rest of error regs */
printk(KERN_EMERG "Calgary: ");
for (i = 0; i < ARRAY_SIZE(errregs); i++) {
- erroff = (0x810 + (i * 0x10)); /* err regs are at 0x810 - 0x870 */
+ /* err regs are at 0x810 - 0x870 */
+ erroff = (0x810 + (i * 0x10));
target = calgary_reg(bbar, phboff | erroff);
errregs[i] = be32_to_cpu(readl(target));
printk("0x%08x@0x%lx ", errregs[i], erroff);
@@ -1209,7 +1212,7 @@ static int __init calgary_init(void)
{
int ret;
struct pci_dev *dev = NULL;
- void* tce_space;
+ void *tce_space;
ret = calgary_locate_bbars();
if (ret)
--
1.5.2
next prev parent reply other threads:[~2007-07-11 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 13:35 Calgary: more updates for 2.6.23 muli
2007-07-11 13:35 ` muli [this message]
2007-07-11 13:35 ` [PATCH 2/4] x86-64: Calgary - tighten up the bitmap locking muli
2007-07-11 13:35 ` [PATCH 3/4] x86-64: Calgary - fold in redundant functions muli
2007-07-11 13:35 ` [PATCH 4/4] x86_64: Calgary - change _map_single, etc to static muli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11841609141802-git-send-email-muli@il.ibm.com \
--to=muli@il.ibm.com \
--cc=ak@suse.de \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.