From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: simon@mungewell.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: add ThingM blink(1) USB RGB LED support
Date: Tue, 22 Jan 2013 09:15:30 -0500 (EST) [thread overview]
Message-ID: <118417672.210985.1358864130303.JavaMail.root@mail.savoirfairelinux.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1301221443320.20374@pobox.suse.cz>
> > The vendor's name is "ThingM" and the product's name is "blink(1)",
> > not "blink".
> > Given that, would you prefer to keep "blink(1)::1234", or would it
> > rather be
> > "thingm-blink1::1234" (avoiding parenthesis)?
> >
> > I ask the same question for the driver name, which is actually
> > "blink(1)".
>
> Actually, for HID bus drivers, we are mostly following the convention
> of
> having just the vendor name in the driver, see hid-microsoft,
> hid-logitech, etc.
>
> So it'd make most sense to me to name the driver hid-thingm, and in
> case
> it is driving blink(1) device (no other devices will be driven by it
> currently), let it create /sys/class/leds/blink1...
Ok, makes sense to me!
Thanks,
Vivien
prev parent reply other threads:[~2013-01-22 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 18:18 [PATCH v2] HID: add ThingM blink(1) USB RGB LED support Vivien Didelot
2013-01-21 18:40 ` simon
2013-01-21 18:40 ` simon
2013-01-21 19:31 ` Vivien Didelot
2013-01-22 10:25 ` Jiri Kosina
2013-01-22 13:39 ` Vivien Didelot
2013-01-22 13:45 ` Jiri Kosina
2013-01-22 14:15 ` Vivien Didelot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=118417672.210985.1358864130303.JavaMail.root@mail.savoirfairelinux.com \
--to=vivien.didelot@savoirfairelinux.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.