From: James Bottomley <James.Bottomley@SteelEye.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: Boaz Harrosh <bharrosh@panasas.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] microtek.c - use data accessors and !use_sg cleanup
Date: Thu, 12 Jul 2007 09:54:04 -0400 [thread overview]
Message-ID: <1184248444.3402.0.camel@localhost.localdomain> (raw)
In-Reply-To: <200707121529.35512.oliver@neukum.org>
On Thu, 2007-07-12 at 15:29 +0200, Oliver Neukum wrote:
> Am Donnerstag, 12. Juli 2007 schrieb Boaz Harrosh:
> >
> > - use scsi_cmnd data accessors
> > - Clean the !use_sg code paths
>
> This doesn't compile, at least on x86_64, so NAK.
>
> Regards
> Oliver
>
> CC [M] drivers/usb/image/microtek.o
> drivers/usb/image/microtek.c: In function ‘mts_data_done’:
> drivers/usb/image/microtek.c:450: warning: implicit declaration of function ‘scsi_set_resid’
> drivers/usb/image/microtek.c: In function ‘mts_command_done’:
> drivers/usb/image/microtek.c:494: warning: implicit declaration of function ‘scsi_sg_count’
> drivers/usb/image/microtek.c: In function ‘mts_do_sg’:
> drivers/usb/image/microtek.c:517: warning: implicit declaration of function ‘scsi_sglist’
> drivers/usb/image/microtek.c:517: warning: assignment makes pointer from integer without a cast
> drivers/usb/image/microtek.c: In function ‘mts_build_transfer_context’:
> drivers/usb/image/microtek.c:553: warning: implicit declaration of function ‘scsi_bufflen’
> drivers/usb/image/microtek.c:558: warning: assignment makes pointer from integer without a cast
These would appear to be because you're not building against scsi-misc
rather than because of a failure in the patch.
James
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-07-12 13:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 18:19 Data accessors more patches Boaz Harrosh
2007-07-04 18:24 ` [PATCH] libata-scsi.c: convert to use the data buffer accessors Boaz Harrosh
2007-07-04 18:26 ` [PATCH] scsi.c: " Boaz Harrosh
2007-07-04 18:28 ` [PATCH] scsi_debug: convert to use the data buffer accessors and !use_sg cleanup Boaz Harrosh
2007-07-12 13:11 ` [PATCH] microtek.c - use data " Boaz Harrosh
2007-07-12 13:24 ` Boaz Harrosh
2007-07-12 16:58 ` Greg KH
2007-07-12 17:04 ` Boaz Harrosh
2007-07-12 17:05 ` James Bottomley
2007-07-12 18:05 ` Greg KH
2007-07-12 13:29 ` Oliver Neukum
2007-07-12 13:54 ` James Bottomley [this message]
2007-07-12 13:56 ` Oliver Neukum
2007-07-12 14:01 ` Boaz Harrosh
2007-07-12 13:58 ` Boaz Harrosh
2007-07-12 13:13 ` Data accessors more patches Boaz Harrosh
2007-07-12 22:37 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184248444.3402.0.camel@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=bharrosh@panasas.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.