From: Daniel Walker <dwalker@mvista.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Oleg Nesterov <oleg@tv-sign.ru>,
Steven Rostedt <rostedt@goodmis.org>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH -rt 3/5] asm/local.h cmpxchg
Date: Sat, 14 Jul 2007 09:52:43 -0700 [thread overview]
Message-ID: <1184431963.2601.8.camel@imap.mvista.com> (raw)
In-Reply-To: <20070714175839.921317000@chello.nl>
On Sat, 2007-07-14 at 19:57 +0200, Peter Zijlstra wrote:
> ===================================================================
> ---
> linux-2.6.22-rc6-mm1.orig/include/asm-generic/local.h 2007-07-12
> 19:44:18.000000000 -0700
> +++ linux-2.6.22-rc6-mm1/include/asm-generic/local.h 2007-07-12
> 19:44:57.000000000 -0700
> @@ -46,13 +46,34 @@ typedef struct
> #define local_add_unless(l, a, u) atomic_long_add_unless((&(l)->a),
> (a), (u))
> #define local_inc_not_zero(l) atomic_long_inc_not_zero(&(l)->a)
>
> -/* Non-atomic variants, ie. preemption disabled and won't be touched
> - * in interrupt, etc. Some archs can optimize this case well. */
> +/*
> + * Establish a state necessary for __local_xx functions to work.
> + */
> +#define __local_begin(flags) local_irq_disable(flags)
Did you mean local_irq_save(flags)? local_irq_disable() doesn't take any
arguments.
Daniel
next prev parent reply other threads:[~2007-07-14 17:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 17:57 [PATCH -rt 0/5] making SLUB -rt friendly Peter Zijlstra
2007-07-14 17:57 ` [PATCH -rt 1/5] workqueue: queue_work_cpu Peter Zijlstra
2007-07-14 17:14 ` Oleg Nesterov
2007-07-14 18:00 ` Peter Zijlstra
2007-07-14 17:57 ` [PATCH -rt 2/5] Thread Migration Preemption - v2 Peter Zijlstra
2007-07-14 16:49 ` Mathieu Desnoyers
2007-07-14 17:16 ` Oleg Nesterov
2007-07-14 17:34 ` Peter Zijlstra
2007-07-14 18:44 ` Peter Zijlstra
2007-07-14 19:07 ` Peter Zijlstra
2007-07-14 20:39 ` Mathieu Desnoyers
2007-07-14 20:48 ` Oleg Nesterov
2007-07-14 20:53 ` Peter Zijlstra
2007-07-14 17:57 ` [PATCH -rt 3/5] asm/local.h cmpxchg Peter Zijlstra
2007-07-14 16:52 ` Daniel Walker [this message]
2007-07-14 17:14 ` Mathieu Desnoyers
2007-07-14 17:31 ` Peter Zijlstra
2007-07-14 18:33 ` Mathieu Desnoyers
2007-07-14 17:57 ` [PATCH -rt 4/5] use migrate_disable for __local_begin Peter Zijlstra
2007-07-14 17:16 ` Mathieu Desnoyers
2007-07-14 17:32 ` Peter Zijlstra
2007-07-14 18:35 ` Mathieu Desnoyers
2007-07-14 18:41 ` Peter Zijlstra
2007-07-14 18:52 ` Mathieu Desnoyers
2007-07-14 17:57 ` [PATCH -rt 5/5] slub: -rt port Peter Zijlstra
2007-07-14 17:39 ` Oleg Nesterov
2007-07-14 17:50 ` Peter Zijlstra
2007-07-14 19:38 ` Oleg Nesterov
2007-07-14 19:49 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184431963.2601.8.camel@imap.mvista.com \
--to=dwalker@mvista.com \
--cc=a.p.zijlstra@chello.nl \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.