From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org, Forrest Zhao <forrest.zhao@gmail.com>
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 1/8] libata-pmp: update ata_eh_reset() for PMP
Date: Mon, 16 Jul 2007 18:46:04 +0900 [thread overview]
Message-ID: <11845791643485-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <1184579163885-git-send-email-htejun@gmail.com>
PMP always requires SRST to be enabled. Also, hardreset reports
classification code from the first device when PMP is attached, not
from the PMP. Update ata_eh_reset() such that followup softreset is
performed if the controller is PMP capable and the host link is being
reset.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-eh.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 3cfa860..bc3e690 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1906,6 +1906,8 @@ static int ata_eh_followup_srst_needed(struct ata_link *link,
return 1;
if (rc != 0)
return 0;
+ if ((link->ap->flags & ATA_FLAG_PMP) && ata_is_host_link(link))
+ return 1;
if (classify && !(link->flags & ATA_LFLAG_ASSUME_CLASS) &&
classes[0] == ATA_DEV_UNKNOWN)
return 1;
--
1.5.0.3
next prev parent reply other threads:[~2007-07-16 9:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 9:46 [PATCHSET 4/4] implement PMP support, take 5 Tejun Heo
2007-07-16 9:46 ` [PATCH 5/8] libata-pmp: implement qc_defer for command switching PMP support Tejun Heo
2007-07-16 9:46 ` [PATCH 2/8] libata-pmp: implement Port Multiplier support Tejun Heo
2007-07-16 9:46 ` [PATCH 3/8] libata-pmp: hook PMP support and enable it Tejun Heo
2007-07-16 9:46 ` Tejun Heo [this message]
2007-07-16 9:46 ` [PATCH 4/8] libata-pmp: extend ACPI support to cover PMP Tejun Heo
2007-07-16 9:46 ` [PATCH 8/8] ahci: implement PMP support Tejun Heo
2007-07-16 9:46 ` [PATCH 6/8] sata_sil24: " Tejun Heo
2007-07-16 9:46 ` [PATCH 7/8] sata_sil24: implement PORT_RST Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11845791643485-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=forrest.zhao@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.