All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karl MacMillan <kmacmillan@mentalrootkit.com>
To: Joshua Brindle <jbrindle@tresys.com>
Cc: selinux@tycho.nsa.gov
Subject: Re: [POLICYREP] [PATCH 1/1] policyrep role implementation
Date: Tue, 17 Jul 2007 14:36:45 -0400	[thread overview]
Message-ID: <1184697405.3833.30.camel@localhost.localdomain> (raw)
In-Reply-To: <469D0522.2010106@tresys.com>

On Tue, 2007-07-17 at 14:06 -0400, Joshua Brindle wrote:
> Joshua Brindle wrote:
> 
> > --- policyrep-roles.orig/libpolicyrep/tests/libpolicyrep-test.cpp
> > +++ policyrep-roles/libpolicyrep/tests/libpolicyrep-test.cpp
> > @@ -39,7 +39,11 @@ void test()
> >          t->attributes().insert("userdomain");
> >          
> >          mod->append_child(t);
> > -        
> > +
> > +	RolePtr r(new Role("foo"));
> > +	r->types().insert("foo");
> > +	mod->append_child(r);       
> > + 
> >  	std::cout << "============ basic test ============" << std::endl;
> >          output_tree(std::cout, pol);
> >          
> 
> One thing I'd like to note, while this simple testing mechanism is 
> working for now as we add more policy components and do more complex 
> things we are going to need something more sophisticated. Should we move 
> to cppunit or boost testing? We are already using boost so it might be 
> worthwhile to use their test suite (though I've never used it so I can't 
> vouch for it.) <http://www.boost.org/libs/test/doc/index.html>
> 

Fine by me - we can at least try it and go for something else if needed.

Karl


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  reply	other threads:[~2007-07-17 18:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-17 17:22 [POLICYREP] [PATCH 0/1] policyrep role implementation Joshua Brindle
2007-07-17 17:22 ` [POLICYREP] [PATCH 1/1] " Joshua Brindle
2007-07-17 18:06   ` Joshua Brindle
2007-07-17 18:36     ` Karl MacMillan [this message]
2007-07-17 18:42   ` Karl MacMillan
2007-07-18 15:11     ` Joshua Brindle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1184697405.3833.30.camel@localhost.localdomain \
    --to=kmacmillan@mentalrootkit.com \
    --cc=jbrindle@tresys.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.