From: "Antonino A. Daplas" <adaplas@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Michal Januszewski <spock@gentoo.org>,
linux-kernel@vger.kernel.org,
Ondrej Zajicek <santiago@crfreenet.org>
Subject: Re: [Linux-fbdev-devel] [PATCH] fbdev: find mode with highest refresh rate in fb_find_mode()
Date: Wed, 18 Jul 2007 23:18:15 +0800 [thread overview]
Message-ID: <1184771895.4523.33.camel@daplas> (raw)
In-Reply-To: <20070718143803.GA5787@localhost.localdomain>
On Wed, 2007-07-18 at 16:38 +0200, Ondrej Zajicek wrote:
> On Wed, Jul 18, 2007 at 10:41:02AM +0200, Michal Januszewski wrote:
> > Currently if the refresh rate is not specified fb_find_mode() returns
> > the first known video mode with the requested resoluion, which provides
> > no guarantees wrt the refresh rate. Change this so that the mode with
> > the highest refresh rate is returned instead.
>
> What refresh rate it sets when used on card or monitor without DDC?
Yes, I noted this also while reviewing patches. fb_find_mode() is used
predominantly with the 'generic' modedb which contains modes that are
not specific to the card or monitor. And fb_try_mode() is not a
guarantee that the returned refresh rate will be safe (we have a lot of
drivers that do not check the timings against the display capabilities).
It would be best that fb_find_mode() return the safest refresh rate
(60Hz) instead of the highest.
Tony
next prev parent reply other threads:[~2007-07-18 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 8:41 [PATCH] fbdev: find mode with highest refresh rate in fb_find_mode() Michal Januszewski
2007-07-18 14:38 ` Ondrej Zajicek
2007-07-18 14:38 ` Ondrej Zajicek
2007-07-18 15:18 ` Antonino A. Daplas [this message]
2007-08-26 19:09 ` Michal Januszewski
2007-08-26 19:09 ` [Linux-fbdev-devel] " Michal Januszewski
2007-08-26 22:49 ` Antonino A. Daplas
2007-08-26 22:49 ` [Linux-fbdev-devel] " Antonino A. Daplas
2007-08-29 22:41 ` [PATCH] fbdev: find mode with the highest/safest " Michal Januszewski
2007-08-29 22:41 ` Michal Januszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184771895.4523.33.camel@daplas \
--to=adaplas@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=santiago@crfreenet.org \
--cc=spock@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.